From: Stephen Hemminger <shemminger@osdl.org>
To: "Hua Zhong" <hzhong@cisco.com>
Cc: akpm@digeo.com, linux-kernel@vger.kernel.org
Subject: Re: Compile warning in 2.5.66-bk latest
Date: Fri, 4 Apr 2003 13:33:20 -0800 [thread overview]
Message-ID: <20030404133320.4a6a2a8c.shemminger@osdl.org> (raw)
In-Reply-To: <CDEDIMAGFBEBKHDJPCLDMEKMDGAA.hzhong@cisco.com>
On Thu, 3 Apr 2003 19:00:14 -0800
"Hua Zhong" <hzhong@cisco.com> wrote:
> Hi Andrew:
>
> It's probably another change set in the file (J_EXPECT_JH).
>
> I don't have gcc 3.2 installed so I could not verify, but maybe the
> following patch could fix it.
>
This compiles and runs fine for me.
> Maybe a better fix is to define all J_EXPECTxxx as sth like:
>
> #define J_EXPECT(expr, why, params...) __journal_expect(expr, why, ##
> params)
>
> as why is always needed.
>
> diff -urN linux-2.5/include/linux/jbd.h linux-2.5-new/include/linux/jbd.h
> --- linux-2.5/include/linux/jbd.h Thu Apr 3 11:29:43 2003
> +++ linux-2.5-new/include/linux/jbd.h Thu Apr 3 21:48:25 2003
> @@ -275,7 +275,7 @@
> do { \
> if (!(expr)) { \
> printk(KERN_ERR "EXT3-fs unexpected failure: %s;\n", # expr); \
> - printk(KERN_ERR ## why); \
> + printk(KERN_ERR why); \
> } \
> } while (0)
> #define J_EXPECT(expr, why...) __journal_expect(expr, ## why)
>
> > -----Original Message-----
> > From: Stephen Hemminger [mailto:shemminger@osdl.org]
> > Sent: Thursday, April 03, 2003 2:17 PM
> > To: Hua Zhong
> > Cc: Linux Kernel Mailing List
> > Subject: Compile warning in 2.5.66-bk latest
> >
> >
> > Using gcc 3.2 with latest 2.5.66-bk
> >
> > gcc -Wp,-MD,drivers/block/.elevator.o.d -D__KERNEL__ -Iinclude
> > -Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing
> > -fno-common -pipe -mpreferred-stack-boundary=2 -march=pentium4
> > -Iinclude/asm-i386/mach-default -nostdinc -iwithprefix include
> > -DKBUILD_BASENAME=elevator -DKBUILD_MODNAME=elevator -c -o
> > drivers/block/.tmp_elevator.o drivers/block/elevator.c
> > fs/jbd/transaction.c:670:53: warning: pasting "KERN_ERR" and
> > ""Possible IO failure.\n"" does not give a valid preprocessing token
> >
> >
> >
prev parent reply other threads:[~2003-04-04 21:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-03 22:17 Stephen Hemminger
2003-04-04 3:00 ` Hua Zhong
2003-04-04 21:33 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030404133320.4a6a2a8c.shemminger@osdl.org \
--to=shemminger@osdl.org \
--cc=akpm@digeo.com \
--cc=hzhong@cisco.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®