From: Andrew Morton <akpm@digeo.com>
To: Zwane Mwaikambo <zwane@linuxpower.ca>
Cc: linux-kernel@vger.kernel.org, mingo@elte.hu,
Linus Torvalds <torvalds@transmeta.com>
Subject: Re: 2.5.66-(bk) == horrible response times for non X11 applications
Date: Sun, 6 Apr 2003 18:24:35 -0700 [thread overview]
Message-ID: <20030406182435.5a243297.akpm@digeo.com> (raw)
In-Reply-To: <Pine.LNX.4.50.0304061757240.2268-100000@montezuma.mastecende.com>
Zwane Mwaikambo <zwane@linuxpower.ca> wrote:
>
> This was not reproduceable with 2.4.18-3 nor with 2.5.66 and the
> following patch applied;
>
> http://www.kernel.org/pub/linux/kernel/people/akpm/patches/2.5/2.5.66/2.5.66-mm3/broken-out/sched-interactivity-backboost-revert.patch
>
There have been multiple reports of this patch fixing starvation problems.
We need to either apply it or fix up the problem by other means.
From: Ingo Molnar <mingo@elte.hu>
the patch below fixes George's setiathome problems (as expected). It
essentially turns off Linus' improvement, but i dont think it can be fixed
sanely.
the problem with setiathome is that it displays something every now and
then - so it gets a backboost from X, and hovers at a relatively high
priority.
kernel/sched.c | 13 +------------
1 files changed, 1 insertion(+), 12 deletions(-)
diff -puN kernel/sched.c~sched-interactivity-backboost-revert kernel/sched.c
--- 25/kernel/sched.c~sched-interactivity-backboost-revert 2003-03-28 22:30:08.000000000 -0800
+++ 25-akpm/kernel/sched.c 2003-03-28 22:30:08.000000000 -0800
@@ -379,19 +379,8 @@ static inline int activate_task(task_t *
* boosting tasks that are related to maximum-interactive
* tasks.
*/
- if (sleep_avg > MAX_SLEEP_AVG) {
- if (!in_interrupt()) {
- sleep_avg += current->sleep_avg - MAX_SLEEP_AVG;
- if (sleep_avg > MAX_SLEEP_AVG)
- sleep_avg = MAX_SLEEP_AVG;
-
- if (current->sleep_avg != sleep_avg) {
- current->sleep_avg = sleep_avg;
- requeue_waker = 1;
- }
- }
+ if (sleep_avg > MAX_SLEEP_AVG)
sleep_avg = MAX_SLEEP_AVG;
- }
if (p->sleep_avg != sleep_avg) {
p->sleep_avg = sleep_avg;
p->prio = effective_prio(p);
_
next prev parent reply other threads:[~2003-04-07 1:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-06 22:36 Zwane Mwaikambo
2003-04-07 1:24 ` Andrew Morton [this message]
2003-04-09 6:42 ` Jakob Oestergaard
2003-04-09 8:01 ` Helge Hafting
2003-04-09 8:52 ` Jakob Oestergaard
2003-04-09 9:10 ` Helge Hafting
2003-04-09 9:26 ` Jakob Oestergaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030406182435.5a243297.akpm@digeo.com \
--to=akpm@digeo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=torvalds@transmeta.com \
--cc=zwane@linuxpower.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®