mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@digeo.com>
To: "Grover, Andrew" <andrew.grover@intel.com>
Cc: zwane@linuxpower.ca, felipe_alfaro@linuxmail.org,
	linux-kernel@vger.kernel.org
Subject: Re: 2.5.66-bk12: acpi_power_off: sleeping function called from il legal context
Date: Mon, 7 Apr 2003 12:06:45 -0700	[thread overview]
Message-ID: <20030407120645.19842977.akpm@digeo.com> (raw)
In-Reply-To: <F760B14C9561B941B89469F59BA3A84725A24D@orsmsx401.jf.intel.com>

"Grover, Andrew" <andrew.grover@intel.com> wrote:
>
> However, we also have to execute control methods early in the boot
> sequence. down() would never block but it thinks it might, so we want to
> call down_trylock instead. in_atomic() seemed to be a good (?) way to
> tell whether we need to avoid down() or not.
> 
> Thoughts on better ways to do this, perhaps? I guess I should at least
> add a comment above that line.
> 

So really it's just the debug code which is being misleading?  hm.

Couldn't you set some magical global ACPI flag:

acpi_super_early_init()
{
	acpi_in_super_early_init = 1;
	do_stuff();
	acpi_in_super_early_init = 0;
}

And test that flag in acpi_os_wait_semaphore()?

It's a bit grubby, but so is the problem.

We do have this `system_running' flags in init/main.c which perhaps should be
fleshed out into a more fine-grained way of communicating the kernel's
start/run/stop state.


      reply	other threads:[~2003-04-07 19:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-04-07 17:56 Grover, Andrew
2003-04-07 19:06 ` Andrew Morton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030407120645.19842977.akpm@digeo.com \
    --to=akpm@digeo.com \
    --cc=andrew.grover@intel.com \
    --cc=felipe_alfaro@linuxmail.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=zwane@linuxpower.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®