mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@digeo.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-kernel@vger.kernel.org, torvalds@transmeta.com
Subject: Re: PATCH: jiffies is UL
Date: Mon, 7 Apr 2003 17:40:27 -0700	[thread overview]
Message-ID: <20030407174027.6f2c7b2d.akpm@digeo.com> (raw)
In-Reply-To: <200304080036.h380aBFH009252@hraefn.swansea.linux.org.uk>

Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
>
> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux-2.5.67/include/linux/time.h linux-2.5.67-ac1/include/linux/time.h
> --- linux-2.5.67/include/linux/time.h	2003-03-06 17:04:37.000000000 +0000
> +++ linux-2.5.67-ac1/include/linux/time.h	2003-03-07 14:57:13.000000000 +0000
> @@ -31,7 +31,7 @@
>   * Have the 32 bit jiffies value wrap 5 minutes after boot
>   * so jiffies wrap bugs show up earlier.
>   */
> -#define INITIAL_JIFFIES ((unsigned int) (-300*HZ))
> +#define INITIAL_JIFFIES ((unsigned long) (-300*HZ))
>  

No, this is deliberate.  It triggers a wrap from 0x00000000ffffffff to
0x0000000100000000 after 5 minutes uptime on 64-bit machines, which has found
bugs.

The fix is to add a comment, so this patch stops coming out ;)



  reply	other threads:[~2003-04-08  0:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-04-08  0:36 Alan Cox
2003-04-08  0:40 ` Andrew Morton [this message]
2003-04-08 12:01   ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030407174027.6f2c7b2d.akpm@digeo.com \
    --to=akpm@digeo.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®