mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chuck Ebbert <76306.1226@compuserve.com>
To: "Petr Vandrovec" <VANDROVE@vc.cvut.cz>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: 2.5.67-mm1 cause framebuffer crash at bootup
Date: Wed, 9 Apr 2003 09:51:57 -0400	[thread overview]
Message-ID: <200304090954_MC3-1-33A8-2B27@compuserve.com> (raw)


> Unfortunately, as proven by i2c, kobjects infrastructure does not like if
> you reference non-existing bus type before it is registered.


  AFAICT sysfs itself sort of has this problem in 2.5.66 -- it tries
to register itself as a filesystem before the set 'fs' is registered.
It retries later and succeeds but I could never figure out if that was
by design or accident. 8)

  This patch helps find some of these problems but I don't think it will
help in this case:


diff -ur --exclude-from=/home/me/exclude linux-2.5.66-ref/lib/kobject.c linux-2.5.66-uni/lib/kobject.c
--- linux-2.5.66-ref/lib/kobject.c	Tue Mar  4 22:29:36 2003
+++ linux-2.5.66-uni/lib/kobject.c	Sat Mar 29 20:43:26 2003
@ -57,10 +57,15 @
 				sysfs_remove_dir(kobj);
 		}
 	}
+	if (error) {
+		printk("Badness name:%s, err:%d, set:%s\n",
+		       kobj->name, error,
+		       kobj->kset ? kobj->kset->kobj.name : "<NULL>");
+		WARN_ON(1);
+	}
 	return error;
 }
 
-
 static inline struct kobject * to_kobj(struct list_head * entry)
 {
 	return container_of(entry,struct kobject,entry);
@ -149,7 +154,6 @
 	if (kobj) {
 		kobject_init(kobj);
 		error = kobject_add(kobj);
-		WARN_ON(error);
 	} else
 		error = -EINVAL;
 	return error;

--
 Chuck

             reply	other threads:[~2003-04-09 13:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-04-09 13:51 Chuck Ebbert [this message]
  -- strict thread matches above, loose matches on Subject: below --
2003-04-09 23:00 Petr Vandrovec
2003-04-09 21:52 Petr Vandrovec
2003-04-09 22:55 ` Randy.Dunlap
2003-04-09 20:58 Petr Vandrovec
2003-04-09 21:45 ` Randy.Dunlap
2003-04-09 12:24 Petr Vandrovec
2003-04-08 11:22 2.5.67-mm1 Andrew Morton
2003-04-09  9:42 ` 2.5.67-mm1 cause framebuffer crash at bootup Helge Hafting
     [not found]   ` <PAO-EX01DJb0LxA56iY0000151b@pao-ex01.pao.digeo.com>
2003-04-09 20:30     ` Randy.Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200304090954_MC3-1-33A8-2B27@compuserve.com \
    --to=76306.1226@compuserve.com \
    --cc=VANDROVE@vc.cvut.cz \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®