From: Dave Jones <davej@codemonkey.org.uk>
To: J?rn Engel <joern@wohnheim.fh-wedel.de>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: top stack (l)users for 2.5.67
Date: Mon, 14 Apr 2003 19:25:53 +0100 [thread overview]
Message-ID: <20030414182544.GA6866@suse.de> (raw)
In-Reply-To: <20030414174645.GK10347@wohnheim.fh-wedel.de>
On Mon, Apr 14, 2003 at 07:46:45PM +0200, J?rn Engel wrote:
> +/* FIXME: should the below go into some header file? */
> +#define PRESTO_COPY_KML_TAIL_BUFSIZE 4096
> struct file * presto_copy_kml_tail(struct presto_file_set *fset,
> unsigned long int start)
> {
so, presto_copy_kml_tail() is only called from
presto_finish_kml_truncate(), which doesn't seem to be called
from anywhere. What am I missing here? Or can this whole lot
just be nuked ?
If not, this patch introduces a problem. You're now
calling a sleeping function (kmalloc) whilst holding
a lock according to the comment above presto_finish_kml_truncate()
Dave
next prev parent reply other threads:[~2003-04-14 18:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-14 17:30 Jörn Engel
2003-04-14 16:37 ` Alan Cox
2003-04-14 17:46 ` Jörn Engel
2003-04-14 18:25 ` Dave Jones [this message]
2003-04-14 19:05 ` Jörn Engel
2003-04-14 19:18 ` Andreas Dilger
2003-04-14 19:40 ` Jörn Engel
2003-04-15 15:38 ` Peter Braam
2003-04-15 9:08 ` Jörn Engel
2003-04-14 19:38 ` Randy.Dunlap
2003-04-14 19:44 ` Jörn Engel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030414182544.GA6866@suse.de \
--to=davej@codemonkey.org.uk \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=joern@wohnheim.fh-wedel.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®