mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@digeo.com>
To: "Philippe Gramoullé" <philippe.gramoulle@mmania.com>
Cc: linux-kernel@vger.kernel.org, Greg KH <greg@kroah.com>
Subject: Re: 2.5.67-mm3: Bad: scheduling while atomic with IEEE1394 then hard freeze ( lockup on CPU0)
Date: Tue, 15 Apr 2003 16:05:30 -0700	[thread overview]
Message-ID: <20030415160530.2520c61c.akpm@digeo.com> (raw)
In-Reply-To: <20030416000501.342c216f.philippe.gramoulle@mmania.com>

Philippe Gramoullé  <philippe.gramoulle@mmania.com> wrote:
>
> 
> http://www.philou.org/2.5.67-mm3/2.5.67-mm3.log

This is a great bug report.  Thanks.

The 1394 warnings are known about and I think Ben is working on it.

The NMI watchdog hit is nasty:

NMI Watchdog detected LOCKUP on CPU0, eip c011eb82, registers:
CPU:    0
EIP:    0060:[<c011eb82>]    Tainted: GF  VLI
EFLAGS: 00200086
EIP is at .text.lock.sched+0x10c/0x12a
eax: d79c8000   ebx: d8c578fc   ecx: 00000000   edx: d8c57800
esi: c03a9d20   edi: d774a0c0   ebp: d79c9d94   esp: d79c9d88
ds: 007b   es: 007b   ss: 0068
Process gkrellm (pid: 458, threadinfo=d79c8000 task=dd7152a0)
Stack: d8c578fc d7eaa400 d774a0c0 d79c9da4 c0235e80 c03a9d20 d77491a0 d79c9db0 
       c0265b88 d8c578fc d79c9dbc e0a9d76c d8c578d0 d79c9de0 e0aa1c61 d8c57800 
       e0a97b62 d7d2f894 00200286 00000008 00000004 e0ab38bc d79c9e08 e0aa25f5 
Call Trace:
 [<c0235e80>] kobject_get+0x70/0x80
 [<c0265b88>] get_device+0x18/0x30
 [<e0a9d76c>] usb_get_dev+0x1c/0x30 [usbcore]
 [<e0aa1c61>] hcd_submit_urb+0x71/0x180 [usbcore]
 [<e0a97b62>] hidinput_report_event+0x32/0x50 [hid]
 [<e0ab38bc>] usb_hcd_operations+0x0/0x24 [usbcore]
 [<e0aa25f5>] usb_submit_urb+0x1d5/0x250 [usbcore]
 [<e0a95274>] hid_irq_in+0x34/0xb0 [hid]
 [<e0aa2104>] usb_hcd_giveback_urb+0x24/0x40 [usbcore]
 [<e0a8f23f>] uhci_finish_completion+0x8f/0xf0 [uhci_hcd]
 [<e0aa214c>] usb_hcd_irq+0x2c/0x60 [usbcore]
 [<c010d7f8>] handle_IRQ_event+0x38/0x60
 [<c010da74>] do_IRQ+0xc4/0x190
 [<c010be0c>] common_interrupt+0x18/0x20
 [<c016007b>] unregister_chrdev_region+0x2b/0x100
 [<c0235e2e>] kobject_get+0x1e/0x80
 [<c018b2a0>] check_perm+0x20/0x120
 [<c0157aa7>] get_empty_filp+0x77/0x100
 [<c0155f5f>] dentry_open+0x21f/0x250
 [<c0155d36>] filp_open+0x66/0x70
 [<c0164423>] getname+0x93/0xd0
 [<c01562c5>] sys_open+0x55/0x90
 [<c010b49f>] syscall_call+0x7/0xb

What has happened here is that you were in the middle of a kobject_get(),
holding spin_lock(&kobj_lock) when an interrupt came in.  The USB interrupt
handler comes in and ends up calling kobject_get() again.  This CPU already
holds the lock and blamyouredead.

Turning kobj_lock into an IRQ-safe lock would appear to be a sufficient fix.


  reply	other threads:[~2003-04-15 22:54 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-04-15 22:05 Philippe Gramoullé
2003-04-15 23:05 ` Andrew Morton [this message]
2003-04-15 23:17   ` Philippe Gramoullé
2003-04-15 23:34     ` Andrew Morton
2003-04-16  5:54       ` Greg KH
2003-04-16 16:58         ` Patrick Mochel
2003-04-16 23:40           ` Philippe Gramoullé
2003-04-17  3:54             ` Greg KH
2003-04-16  0:49   ` Ben Collins
2003-04-16 16:45     ` Philippe Gramoullé
2003-04-16 17:32       ` Steve Kinneberg
2003-04-16 22:30         ` Philippe Gramoullé
2003-04-16 23:35           ` Steve Kinneberg
2003-04-16 23:52             ` Philippe Gramoullé
2003-04-17  2:48           ` Dan Maas
2003-04-16 18:09       ` Ben Collins
2003-04-18 18:51   ` Florin Iucha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030415160530.2520c61c.akpm@digeo.com \
    --to=akpm@digeo.com \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=philippe.gramoulle@mmania.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®