From: Arnd Bergmann <arnd@arndb.de>
To: Carl-Daniel Hailfinger <c-d.hailfinger.kernel.2003@gmx.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [2.5] include/asm-generic/bitops.h {set,clear}_bit return void
Date: Tue, 15 Apr 2003 22:04:59 +0200 [thread overview]
Message-ID: <200304152007.h3FK72sD003180@post.webmailer.de> (raw)
In-Reply-To: <20030415174010$3e7e@gated-at.bofh.it>
Carl-Daniel Hailfinger wrote:
> + mask = 1 << (nr & 0x1f);
> + cli();
> + *addr |= mask;
> + sti();
cli() and sti() are no more. Moreover, the file you are trying to fix is
not even used anywhere. Better submit a patch to remove it completely.
Arnd <><
next parent reply other threads:[~2003-04-15 19:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20030415174010$3e7e@gated-at.bofh.it>
2003-04-15 20:04 ` Arnd Bergmann [this message]
2003-04-15 21:27 ` Carl-Daniel Hailfinger
2003-04-15 21:34 ` Robert Love
2003-04-15 22:46 ` Arnd Bergmann
2003-04-23 18:04 ` Pavel Machek
2003-04-15 17:36 Carl-Daniel Hailfinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200304152007.h3FK72sD003180@post.webmailer.de \
--to=arnd@arndb.de \
--cc=c-d.hailfinger.kernel.2003@gmx.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®