From: Andrew Morton <akpm@digeo.com>
To: Andries.Brouwer@cwi.nl
Cc: torvalds@transmeta.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] struct loop_info
Date: Thu, 17 Apr 2003 17:22:12 -0700 [thread overview]
Message-ID: <20030417172212.02e0e3a1.akpm@digeo.com> (raw)
In-Reply-To: <UTC200304172334.h3HNYgI06614.aeb@smtp.cwi.nl>
Andries.Brouwer@cwi.nl wrote:
>
> Until now as the source already says, we had a very unpleasant
> situation with struct loop_info:
This patch makes me pull faces, sorry.
a) The name "loop_info2" is meaningless. Something like loop_info64 would
communicate something to the reader.
b) It is impossible for the reader to tell _why_ loop_info and loop_info2
exist.
It will be especially mysterious in 2.8, where there is no loop_info,
only a loop_info2.
Hence covering commentary is compulsory.
c) Could we not save a lot of noise by putting:
typedef unsigned short legacy_dev_t; /* <= linux-2.4.x */
into asm/posix_types.h and then keep all this stuff just in
<linux/loop.h>?
d) Would it be possible to just add a u64 to the _end_ of the existing
loop_info and, in the legacy ioctl(), simply massage it?
next prev parent reply other threads:[~2003-04-18 0:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-17 23:34 Andries.Brouwer
2003-04-18 0:22 ` Andrew Morton [this message]
2003-04-18 5:05 ` Andreas Dilger
2003-04-18 13:24 ` Jari Ruusu
2003-04-18 8:38 Andries.Brouwer
2003-04-18 9:06 Andries.Brouwer
2003-04-18 9:12 ` Christoph Hellwig
2003-04-18 9:36 Andries.Brouwer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030417172212.02e0e3a1.akpm@digeo.com \
--to=akpm@digeo.com \
--cc=Andries.Brouwer@cwi.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®