From: Christoph Hellwig <hch@lst.de>
To: torvalds@transmeta.com
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] devfs (1/7) - fix compilation
Date: Fri, 18 Apr 2003 18:12:46 +0200 [thread overview]
Message-ID: <20030418181246.A363@lst.de> (raw)
As several people found out while I was asleep I sent you
a bogus patch version and devfs didn't compile in your
tree since then. Fix it.
diff -Nru a/fs/devfs/base.c b/fs/devfs/base.c
--- a/fs/devfs/base.c Fri Apr 18 15:56:18 2003
+++ b/fs/devfs/base.c Fri Apr 18 15:56:18 2003
@@ -1377,7 +1377,6 @@
* @uid: The user ID.
* @gid: The group ID.
* @fs_info: The filesystem info.
- * @atomic: If TRUE, an atomic allocation is required.
*
* Returns %TRUE if an event was queued and devfsd woken up, else %FALSE.
*/
@@ -1423,7 +1422,7 @@
static void devfsd_notify (struct devfs_entry *de,unsigned short type)
{
devfsd_notify_de(de, type, de->mode, current->euid,
- current->egid, &fs_info, 0);
+ current->egid, &fs_info);
}
@@ -1456,8 +1455,8 @@
dev_t devnum = 0, dev = MKDEV(major, minor);
struct devfs_entry *de;
- if (flags)
- printk(KERN_ERR "%s called with flags != 0, please fix!\n");
+ /* we don't accept any flags anymore. prototype will change soon. */
+ BUG_ON(flags);
if (name == NULL)
{
next reply other threads:[~2003-04-18 16:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-18 16:12 Christoph Hellwig [this message]
2003-04-18 16:19 ` Linus Torvalds
2003-04-18 16:21 ` Christoph Hellwig
2003-04-18 16:26 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030418181246.A363@lst.de \
--to=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®