From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263460AbTDSUjs (ORCPT ); Sat, 19 Apr 2003 16:39:48 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263461AbTDSUjs (ORCPT ); Sat, 19 Apr 2003 16:39:48 -0400 Received: from electric-eye.fr.zoreil.com ([213.41.134.224]:44300 "EHLO fr.zoreil.com") by vger.kernel.org with ESMTP id S263460AbTDSUjr (ORCPT ); Sat, 19 Apr 2003 16:39:47 -0400 Date: Sat, 19 Apr 2003 22:43:50 +0200 From: Francois Romieu To: Jeff Garzik Cc: Alan Cox , linux-kernel@vger.kernel.org Subject: Re: [PATCH] drivers/net/rcpci45 DMA mapping API conversion Message-ID: <20030419224350.B3020@electric-eye.fr.zoreil.com> References: <20030105144559.A2835@se1.cogenit.fr> <3EA19CF8.8030109@pobox.com> <20030419215526.A3020@electric-eye.fr.zoreil.com> <3EA1ACDD.4090306@pobox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <3EA1ACDD.4090306@pobox.com>; from jgarzik@pobox.com on Sat, Apr 19, 2003 at 04:09:01PM -0400 X-Organisation: Marie's fan club - III Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Jeff Garzik : [...] > Francois Romieu wrote: [...] > > Jeff Garzik : > > [...] > > > >>Ok, I finally got around to attacking this one. Your patch looked ok to > >>me until I noticed one detail: > >> > >> pDpa->msgbuf = kmalloc (MSG_BUF_SIZE, GFP_DMA | GFP_KERNEL); > >> > >>The GFP_DMA tag indicates that we can't just use pci_alloc_consistent in > >>the normal way, as we lose the GFP_DMA designator. > > > > > > Does it mean the usual pci_set_dma_mask() cooking or something more > > elaborate ? > > > Reading dma_alloc_coherent() in arch/i386/kernel/pci-dma.c, it does > appear that would be sufficient... I'll cook something like that then. Anyway, I'm curious to know whether someone[1] can come with a specific mask for this device or (even better) say that the GFP_DMA wasn't really needed in the first place. [1] driver claims: ** Ported to 2.1.x by Alan Cox 1998/12/9. Any hint Mr Cox ? -- Ueimor