mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Stephane Ouellette <ouellettes@videotron.ca>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH]  Undefined symbol sync_dquots_dev() in quota.c
Date: Wed, 23 Apr 2003 12:02:44 -0400	[thread overview]
Message-ID: <20030423160244.GB5561@gtf.org> (raw)
In-Reply-To: <3EA6B854.5010604@videotron.ca>

On Wed, Apr 23, 2003 at 11:59:16AM -0400, Stephane Ouellette wrote:
> Jeff Garzik wrote:
> 
> >On Wed, Apr 23, 2003 at 11:28:58AM -0400, Stephane Ouellette wrote:
> > 
> >
> >>Folks,
> >>
> >> the following patch fixes a compile error under 2.4.21-rc1-ac1. 
> >>sync_dev_dquots() is undefined if CONFIG_QUOTA is not set.
> >>   
> >>
> >
> >The right fix would be to make sure a no-op version of sync_dev_dquots
> >exists for that case.
> >
> >	Jeff
> > 
> >
> 
> Jeff,
> 
>   the file fs/dquot.c is compiled only if CONFIG_QUOTA is set.  That 
> would imply modifying the Makefile and #ifdeffing most of the code 
> inside dquot.c.

So?  ;-)

Your patch modified fs/quota.c, which is compiled when CONFIG_QUOTACTL is
set, which in turn is set for CONFIG_QUOTA || CONFIG_XFS_QUOTA.

If you are adding CONFIG_QUOTA ifdefs to fs/quota.c, it is clear a
non-ifdef solution can be achieved.

	Jeff




  reply	other threads:[~2003-04-23 15:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-04-23 15:28 Stephane Ouellette
2003-04-23 15:33 ` Jeff Garzik
2003-04-23 15:59   ` Stephane Ouellette
2003-04-23 16:02     ` Jeff Garzik [this message]
2003-04-23 20:32       ` pixi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030423160244.GB5561@gtf.org \
    --to=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ouellettes@videotron.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®