From: Rusty Russell <rusty@rustcorp.com.au>
To: Petr Vandrovec <vandrove@vc.cvut.cz>
Cc: linux-kernel@vger.kernel.org, torvalds@transmeta.com
Subject: Re: [PATCH] Oopses in apply_alternatives
Date: Thu, 24 Apr 2003 13:12:10 +1000 [thread overview]
Message-ID: <20030424043357.5B9312C08B@lists.samba.org> (raw)
In-Reply-To: Your message of "Wed, 23 Apr 2003 23:30:38 +0200." <20030423213038.GA6389@vana.vc.cvut.cz>
In message <20030423213038.GA6389@vana.vc.cvut.cz> you write:
> Hi Rusty,
> I somehow missed apply_alternatives inclusion into the kernel, so
> I have no idea whether you are right person...
>
> It is not good idea to call apply_alternatives from module_finalize,
> as apply_alternatives is __init function... It spectaculary crashed
Smells of Torvaldism. I missed it too: you're right,
apply_alternatives should be marked
__init_or_module
instead.
Thanks!
Rusty.
> @@ -802,7 +802,7 @@
> APs have less capabilities than the boot processor are not handled.
>
> In this case boot with "noreplacement". */
> -void __init apply_alternatives(void *start, void *end)
> +void apply_alternatives(void *start, void *end)
> {
> struct alt_instr *a;
> int diff, i, k;
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
prev parent reply other threads:[~2003-04-24 4:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-23 21:30 Petr Vandrovec
2003-04-24 3:12 ` Rusty Russell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030424043357.5B9312C08B@lists.samba.org \
--to=rusty@rustcorp.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
--cc=vandrove@vc.cvut.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®