From: "Jörn Engel" <joern@wohnheim.fh-wedel.de>
To: "Randy.Dunlap" <randy.dunlap@verizon.net>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: Re: missing #includes?
Date: Sat, 26 Apr 2003 22:31:36 +0200 [thread overview]
Message-ID: <20030426203136.GA3456@wohnheim.fh-wedel.de> (raw)
In-Reply-To: <20030425235119.6f337e70.randy.dunlap@verizon.net>
On Fri, 25 April 2003 23:51:19 -0700, Randy.Dunlap wrote:
>
> I wrote a trivial bash script to check if <sourcefiles> #include
> <headerfile> when <symbol> is used. Run it at top of kernel tree,
> like so:
>
> $ check-header STACK_MAGIC linux/kernel.h
> error: linux/kernel.h not found in ./arch/h8300/kernel/traps.c
>
>
> What's the preferred thing to do here? I would like to see explicit
> #includes when symbols are used. Is that what others expect also?
>
> However, it makes for quite a large list of missing includes.
As long as it doesn't change the kernel binary, I don't have a strong
opinion. Explicit #includes are nicer, but is it worth the trouble?
Do the implicit #includes hurt anywhere? I don't know.
Jörn
--
Those who come seeking peace without a treaty are plotting.
-- Sun Tzu
next prev parent reply other threads:[~2003-04-26 20:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-26 6:51 Randy.Dunlap
2003-04-26 20:17 ` Thunder Anklin
2003-04-26 20:36 ` Jörn Engel
2003-04-26 20:31 ` Jörn Engel [this message]
2003-04-26 20:36 ` Randy.Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030426203136.GA3456@wohnheim.fh-wedel.de \
--to=joern@wohnheim.fh-wedel.de \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@verizon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®