Re: 2.4.21-rc1 compile failure [toshoboe]

[Jean Tourrilhes <jt@bougret.hpl.hp.com>]

On Wed, Apr 30, 2003 at 07:45:30PM +0200, Pavel Machek wrote:
> Hi!
> 
> > > I get compile failure for 2.4.21-rc1:
> > > 
> > > "in irda_device_init: undefined reference to toshoboe_init".
> > 
> > 	Non-modular IrDA is not supported in 2.4.X and is known to be
> > broken in various way (see bottom of my web page). This was fixed in
> > 2.5.24, but won't be fixed in the 2.4.X serie. However, I always
> > accept trivial patches...
> > 	Have fun...
> 
> Fix was to kill toshoboe_init() from irda_device_init(): it is
> module_init() so it gets called, anyway.

	Actually, it should probably be encapsualted in
TOSHIBA_OLD. But unfortunately, there is more than that, trust me.

> Unfortunately toshoboe in 2.4.21-rc1 works as badly as in 2.5: the
> "new" driver does not even detect it and the "old" driver breaks with
> max_baud > 9600.

	First, please verify if you have the same problem when the
full IrDA stack and drivers are modular.
	I would expect the same behaviour in 2.5.X and 2.4.X, because
it's the same driver. I personally don't have this hardware, so can't
do much, and the maintainer are unresponsive. It supposed to work
better if you pass the flag to bypass the self test.
	Also, most modern Toshiba laptops seems to have SMC instead of
toshoboe hardware.

> 								Pavel

	Good luck...

	Jean