From: Gabriel Devenyi <devenyga@mcmaster.ca>
To: khc@pm.waw.pl
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] Linux 2.5.68 - Fix module_put after return in drivers/net/wan/n2.c
Date: Thu, 1 May 2003 15:58:30 -0400 [thread overview]
Message-ID: <200305011558.32475.devenyga@mcmaster.ca> (raw)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
This patch applies to 2.5.68. It is a bug listed at kbugs.org. module_put is never executed because it is after return.
Please CC me with any discussion.
- --
Building the Future,
Gabriel Devenyi
devenyga@mcmaster.ca
- ---FILE---
- --- linux-2.5.68/drivers/net/wan/n2.c 2003-04-19 22:48:55.000000000 -0400
+++ linux-2.5.68-changed/drivers/net/wan/n2.c 2003-05-01 15:05:36.000000000 -0400
@@ -223,8 +223,8 @@
int result = hdlc_open(hdlc);
if (result) {
- - return result;
module_put(THIS_MODULE);
+ return result;
}
mcr &= port->phy_node ? ~DTR_PORT1 : ~DTR_PORT0; /* set DTR ON */
- ---ENDFILE---
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)
iD8DBQE+sXxm7I5UBdiZaF4RAu8kAJ0RKpz8xwzNovBJIgD/vd4f4hEAzQCeNKpI
USAyeWl6lmsVqOPEzV/r1tI=
=rplC
-----END PGP SIGNATURE-----
next reply other threads:[~2003-04-30 19:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-01 19:58 Gabriel Devenyi [this message]
2003-04-30 22:00 ` Francois Romieu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200305011558.32475.devenyga@mcmaster.ca \
--to=devenyga@mcmaster.ca \
--cc=khc@pm.waw.pl \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®