From: Bob Miller <rem@osdl.org>
To: linux-kernel@vger.kernel.org
Cc: trivial@rustcorp.com.au
Subject: [PATCH 2.5.68] Convert octagon-5066 to remove check_region().
Date: Fri, 2 May 2003 13:42:57 -0700 [thread overview]
Message-ID: <20030502204257.GC25713@doc.pdx.osdl.net> (raw)
Moved the request_region() call to replace check_region() and adds
release_region()'s in the error paths that occure before the old
call to request_region().
--
Bob Miller Email: rem@osdl.org
Open Source Development Lab Phone: 503.626.2455 Ext. 17
diff -Nru a/drivers/mtd/maps/octagon-5066.c b/drivers/mtd/maps/octagon-5066.c
--- a/drivers/mtd/maps/octagon-5066.c Fri May 2 09:52:22 2003
+++ b/drivers/mtd/maps/octagon-5066.c Fri May 2 09:52:22 2003
@@ -231,7 +231,7 @@
int i;
// Do an autoprobe sequence
- if (check_region(PAGE_IO,1) != 0)
+ if (!request_region(PAGE_IO,1,"Octagon SSD"))
{
printk("5066: Page Register in Use\n");
return -EAGAIN;
@@ -239,16 +239,16 @@
iomapadr = (unsigned long)ioremap(WINDOW_START, WINDOW_LENGTH);
if (!iomapadr) {
printk("Failed to ioremap memory region\n");
+ release_region(PAGE_IO,1);
return -EIO;
}
if (OctProbe() != 0)
{
printk("5066: Octagon Probe Failed, is this an Octagon 5066 SBC?\n");
iounmap((void *)iomapadr);
+ release_region(PAGE_IO,1);
return -EAGAIN;
}
-
- request_region(PAGE_IO,1,"Octagon SSD");
// Print out our little header..
printk("Octagon 5066 SSD IO:0x%x MEM:0x%x-0x%x\n",PAGE_IO,WINDOW_START,
reply other threads:[~2003-05-02 20:30 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030502204257.GC25713@doc.pdx.osdl.net \
--to=rem@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=trivial@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®