From: Chuck Ebbert <76306.1226@compuserve.com>
To: Geller Sandor <wildy@petra.hos.u-szeged.hu>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: compile fix for IBM PCI hotplug driver (linux 2.4.21rc1-ac4)
Date: Sun, 4 May 2003 10:39:23 -0400 [thread overview]
Message-ID: <200305041040_MC3-1-3755-1BD@compuserve.com> (raw)
> if(create_file_name (slot_cur, buf)==0)
Wow. Three whitespace violations on one line:
- no space after 'if'
- space between function and args
- no space around '==' operator
I know you didn't write that, I just had to comment because it almost
hurts to look at it...
>- snprintf (slot_cur->hotplug_slot->name, 30, "%s", );
>+ snprintf (slot_cur->hotplug_slot->name, 30, "%s" );
Doesn't this need a fourth parameter here instead of just
removing the comma?
next reply other threads:[~2003-05-04 14:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-04 14:39 Chuck Ebbert [this message]
2003-05-04 18:36 ` Geller Sandor
-- strict thread matches above, loose matches on Subject: below --
2003-05-04 14:01 Geller Sandor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200305041040_MC3-1-3755-1BD@compuserve.com \
--to=76306.1226@compuserve.com \
--cc=linux-kernel@vger.kernel.org \
--cc=wildy@petra.hos.u-szeged.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®