mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: Bob Miller <rem@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.5.68] Convert elan-104nc to remove check_region().
Date: Mon, 05 May 2003 14:38:02 +1000	[thread overview]
Message-ID: <20030505044653.D296B2C255@lists.samba.org> (raw)
In-Reply-To: Your message of "Fri, 02 May 2003 13:42:07 MST." <20030502204207.GB25713@doc.pdx.osdl.net>

In message <20030502204207.GB25713@doc.pdx.osdl.net> you write:
> Moved the request_region() call to replace check_region() and adds
> release_region()'s in the error paths that occure before the old
> call to request_region().

>  NOTE: This patch just updates comments.

Actually. It doesn't.

And why this:

> @@ -227,14 +227,14 @@
>  	}
>  
>  	iounmap((void *)iomapadr);
> -	release_region(PAGE_IO,PAGE_IO_SIZE);
> +	/* release_region(PAGE_IO,PAGE_IO_SIZE); */
>  }

Rusty.
--
  Anyone who quotes me in their sig is an idiot. -- Rusty Russell.

  reply	other threads:[~2003-05-05  4:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-05-02 20:42 Bob Miller
2003-05-05  4:38 ` Rusty Russell [this message]
2003-05-05 17:01   ` Bob Miller
2003-05-06  1:04     ` Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030505044653.D296B2C255@lists.samba.org \
    --to=rusty@rustcorp.com.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rem@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®