From: Andi Kleen <ak@suse.de>
To: mikpe@csd.uu.se
Cc: ak@suse.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix x86_64 pte_user() and floppy.h for 2.5.69
Date: Tue, 6 May 2003 16:22:52 +0200 [thread overview]
Message-ID: <20030506142252.GB28449@Wotan.suse.de> (raw)
In-Reply-To: <16055.49364.106094.795419@gargle.gargle.HOWL>
On Tue, May 06, 2003 at 04:04:04PM +0200, mikpe@csd.uu.se wrote:
> Andi,
>
> 2.5.69 failed to link on x86_64 due to a missing reference to pte_user().
> I simply stole the one that i386 added in .68 -> .69.
> There's also irqreturn_t warnings on floppy.h -- fixed also by syncing
> with i386' floppy.h.
At least the floppy.h thing is already fixed.
The pte_user fix is not needed. The correct fix is to change the
#ifdef mm/memory.c checks for. It's broken for most/all
architecture which are not i386 including x86-64.
They have FIXADDR_START, but don't need this check and it's even
wrong to have it.
It should be probably just #ifdef __i386__ instead of checking
such common symbols or better just be moved into arch/i386/mm/fault.c
-Andi
next prev parent reply other threads:[~2003-05-06 14:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-06 14:04 mikpe
2003-05-06 14:22 ` Andi Kleen [this message]
2003-05-06 14:26 ` mikpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030506142252.GB28449@Wotan.suse.de \
--to=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mikpe@csd.uu.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®