mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@redhat.com>
To: chas@cmf.nrl.navy.mil
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH][ATM] assorted atm patches
Date: Wed, 07 May 2003 11:28:41 -0700 (PDT)	[thread overview]
Message-ID: <20030507.112841.63035160.davem@redhat.com> (raw)
In-Reply-To: <200305071841.h47IfGW00890@relax.cmf.nrl.navy.mil>

   From: chas williams <chas@cmf.nrl.navy.mil>
   Date: Wed, 7 May 2003 14:41:16 -0400

   [ATM]: drivers/atm/Makefile does not need this
   
Applied.

   [ATM]: ixmicro (now rapidwan) produces a version of these cards but
          they put the end station identifier (mac address to etherheads)
          in a different location in the eeprom.
   
Applied.

   [ATM]: its a good idea to make sure skb->cb is empty before passing the
          pdu's to the network stack (this will bite you on 64-bit platforms
          eventually)
   
Applied.  You appended the patch twice though, but I figured
that out before I applied it :-)

   [ATM]: ATM_PDU_OVHD is 0, isnt used consistently and probably should
          just go away (it might be more useful to have something like 
          hard_trailer_len).  overloading driver->tx_alloc() doesnt work
          for skb's coming from the network.  the driver->send() routine
          should just deal with poorly aligned skb's.  the default 
          alignment from alloc_tx() meets the needs for all drivers.
          further, no driver actually takes advantage of this feature.
          driver->free_rx_skb() isn't used and should just go away.
   
Applied.
   
   [ATM]: cleanup some oddities in the he driver (most are historical
          for one reason or another -- at one point iov_base did actually
          hold a pointer)  also, fixed a comment that was wrong.  the
          he finally has aal0 transmit support.
   
Applied, thanks Chas.

  reply	other threads:[~2003-05-07 19:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-05-07 18:41 chas williams
2003-05-07 18:28 ` David S. Miller [this message]
2003-05-07 19:41   ` chas williams
2003-05-07 18:39     ` David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030507.112841.63035160.davem@redhat.com \
    --to=davem@redhat.com \
    --cc=chas@cmf.nrl.navy.mil \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®