mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Jörn Engel" <joern@wohnheim.fh-wedel.de>
To: Andi Kleen <ak@muc.de>
Cc: torvalds@transmeta.com, akpm@digeo.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix .altinstructions linking failures
Date: Wed, 7 May 2003 11:23:29 +0200	[thread overview]
Message-ID: <20030507092329.GA2389@wohnheim.fh-wedel.de> (raw)
In-Reply-To: <20030506063055.GA15424@averell>

On Tue, 6 May 2003 08:30:55 +0200, Andi Kleen wrote:
> 
> Some configs didn't link anymore because they got references from
> .altinstructions to __exit functions. Fixing it at the linker level
> is not easily possible. This patch just discards .text.exit at runtime
> instead of link time to avoid this.
> 
> Idea from Andrew Morton.
> 
> It will also fix a related problem with .eh_frame in modern gcc (so far 
> only observed on x86-64, but could happen on i386 too) 

But it sure won't make any embedded people happy. This adds .text.exit
(and .data.exit?) to the kernel image, which is nothing but
unnecessary bloat. Nothing inside those sections is ever used, yet
their footprint does hurt on small systems.

I've been a bit sceptical of the whole .altinstructions idea,
self-modifying code opens a can of worms for anyone trying to do code
analysis (coverage, verification,...). But with this followup, I
personally pay money to get that stuff ripped out again.

Jörn

-- 
The cost of changing business rules is much more expensive for software
than for a secretaty.
-- unknown

  parent reply	other threads:[~2003-05-07  9:11 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-05-06  6:30 Andi Kleen
2003-05-06 16:44 ` Adrian Bunk
2003-05-06 19:56   ` Andi Kleen
2003-05-06 21:08     ` Andi Kleen
2003-05-06 21:25       ` Andrew Morton
2003-05-06 21:45         ` Andi Kleen
2003-05-07  9:23 ` Jörn Engel [this message]
2003-05-07  9:47   ` Andi Kleen
2003-05-07 10:16     ` Jörn Engel
2003-05-07 16:38     ` Greg KH
2003-05-10  8:50     ` Adrian Bunk
2003-05-10 15:41       ` Jörn Engel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030507092329.GA2389@wohnheim.fh-wedel.de \
    --to=joern@wohnheim.fh-wedel.de \
    --cc=ak@muc.de \
    --cc=akpm@digeo.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®