From: Christoph Hellwig <hch@infradead.org>
To: Gregoire Favre <greg@ulima.unil.ch>
Cc: linux-kernel@vger.kernel.org
Subject: Re: lilo and 2.5.69?
Date: Sun, 11 May 2003 14:56:10 +0100 [thread overview]
Message-ID: <20030511145610.B20017@infradead.org> (raw)
In-Reply-To: <20030511130945.GA10607@ulima.unil.ch>; from greg@ulima.unil.ch on Sun, May 11, 2003 at 03:09:45PM +0200
On Sun, May 11, 2003 at 03:09:45PM +0200, Gregoire Favre wrote:
> Is there something special to do with this new kernel?
You need to fix lilo to not assume the names listet in /proc/partitions are
actual device files. In 2.5.69 there's a bug that it prints truncated devfs
names instead of traditional device names as it should, but relying on the
names to mean anything is broken - that kernel can't enforce the device names
used.
The following patch that is in Linus BK tree should get it working for you
again for now..
--- 1.108/fs/partitions/check.c Tue Apr 29 17:42:50 2003
+++ edited/fs/partitions/check.c Fri May 2 09:41:04 2003
@@ -96,19 +96,6 @@
char *disk_name(struct gendisk *hd, int part, char *buf)
{
-#ifdef CONFIG_DEVFS_FS
- if (hd->devfs_name[0] != '\0') {
- if (part)
- snprintf(buf, BDEVNAME_SIZE, "%s/part%d",
- hd->devfs_name, part);
- else if (hd->minors != 1)
- snprintf(buf, BDEVNAME_SIZE, "%s/disc", hd->devfs_name);
- else
- snprintf(buf, BDEVNAME_SIZE, "%s", hd->devfs_name);
- return buf;
- }
-#endif
-
if (!part)
snprintf(buf, BDEVNAME_SIZE, "%s", hd->disk_name);
else if (isdigit(hd->disk_name[strlen(hd->disk_name)-1]))
next prev parent reply other threads:[~2003-05-11 13:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-11 13:09 Gregoire Favre
2003-05-11 13:56 ` Christoph Hellwig [this message]
2003-05-11 14:22 ` Helge Hafting
2003-05-11 14:24 ` Gregoire Favre
[not found] <fa.esb041l.fng3gd@ifi.uio.no>
[not found] ` <fa.fb22044.i12sp4@ifi.uio.no>
2003-05-11 14:33 ` Gregoire Favre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030511145610.B20017@infradead.org \
--to=hch@infradead.org \
--cc=greg@ulima.unil.ch \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®