From: "David S. Miller" <davem@redhat.com>
To: chas@locutus.cmf.nrl.navy.mil
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH][ATM] make clip modular
Date: Mon, 12 May 2003 13:26:41 -0700 (PDT) [thread overview]
Message-ID: <20030512.132641.35021107.davem@redhat.com> (raw)
In-Reply-To: <200305122126.h4CLQ4Gi030745@locutus.cmf.nrl.navy.mil>
From: chas williams <chas@locutus.cmf.nrl.navy.mil>
Date: Mon, 12 May 2003 17:26:04 -0400
how about this for now for clip (lane et al will come later):
Still buggy.
...
-#ifdef CONFIG_ATM_CLIP
+#if defined(CONFIG_ATM_CLIP) || defined(CONFIG_ATM_CLIP_MODULE)
case SIOCMKCLIP:
if (!capable(CAP_NET_ADMIN))
ret_val = -EPERM;
else
- ret_val = clip_create(arg);
+ ret_val = atm_clip_ops->clip_create(arg);
goto done;
Do you know that atm_clip_ops is non-NULL here? How is that?
Also how can you legally call into a module without having a reference
to it or somehow otherwise blocking it's unloading (f.e. by holding
the ops semaphore)?
Chas, please think carefully about this problem.
next prev parent reply other threads:[~2003-05-12 21:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-12 19:33 chas williams
2003-05-12 18:57 ` David S. Miller
2003-05-12 21:26 ` chas williams
2003-05-12 20:26 ` David S. Miller [this message]
2003-05-12 21:40 ` chas williams
[not found] ` <200305132131.h4DLVGGi003551@locutus.cmf.nrl.navy.mil>
2003-05-14 0:05 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030512.132641.35021107.davem@redhat.com \
--to=davem@redhat.com \
--cc=chas@locutus.cmf.nrl.navy.mil \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®