From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262099AbTELMzy (ORCPT ); Mon, 12 May 2003 08:55:54 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262102AbTELMzx (ORCPT ); Mon, 12 May 2003 08:55:53 -0400 Received: from phoenix.mvhi.com ([195.224.96.167]:19982 "EHLO phoenix.infradead.org") by vger.kernel.org with ESMTP id S262099AbTELMzv (ORCPT ); Mon, 12 May 2003 08:55:51 -0400 Date: Mon, 12 May 2003 14:08:34 +0100 From: Christoph Hellwig To: Pavel Machek Cc: Christoph Hellwig , kernel list Subject: Re: ioctl32: kill code duplication (sparc64 tester wanted) Message-ID: <20030512140834.A29260@infradead.org> Mail-Followup-To: Christoph Hellwig , Pavel Machek , kernel list References: <20030512114055.GA3539@atrey.karlin.mff.cuni.cz> <20030512134353.A28931@infradead.org> <20030512130518.GA15227@atrey.karlin.mff.cuni.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <20030512130518.GA15227@atrey.karlin.mff.cuni.cz>; from pavel@ucw.cz on Mon, May 12, 2003 at 03:05:19PM +0200 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 12, 2003 at 03:05:19PM +0200, Pavel Machek wrote: > Hi! > > I don't have a sparc64, but there's certainly no for > > > that arch.. > > I thought I killed that one? The patch you attached added it.. > > Also #including c files is ugly as hell. What's the #ifdef INCLUDES > > supposed to help? > > Yes, but do you have better proposal how to kill 4000+ lines of code > from each 64-bit architecture? What's the reason you can't build fs/compat_ioctl.c normally and pull in the arch magic through a magic asm/ header? You still haven't answered the second question, btw..