From: Richard Curnow <Richard.Curnow@superh.com>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [PATCH] ehci-hcd.c needs to include <linux/bitops.h>
Date: Tue, 13 May 2003 16:53:41 +0100 [thread overview]
Message-ID: <20030513155341.GB1609@malvern.uk.w2k.superh.com> (raw)
When I try to configure in EHCI support without this patch, I get
generic_ffs undefined at link time. (This is with 2.4.21-rc2 on our
sh64 (SH-5) port). Perhaps there are other ways to achieve this, but
this worked for me.
# This is a BitKeeper generated patch for the following project:
# Project Name: Linux kernel tree
# This patch format is intended for GNU patch command version 2.5 or higher.
# This patch includes the following deltas:
# ChangeSet 1.1212 -> 1.1213
# drivers/usb/host/ehci-hcd.c 1.12 -> 1.13
#
# The following is the BitKeeper ChangeSet Log
# --------------------------------------------
# 03/05/13 curnowr@linsvr6.uk.superh.com 1.1213
# ehci-hcd.c needs to include <linux/bitops.h>, otherwise the inline
# definition of generic_ffs is not visible and it becomes an undefined
# symbol at link time.
# --------------------------------------------
#
diff -Nru a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c
--- a/drivers/usb/host/ehci-hcd.c Tue May 13 16:50:22 2003
+++ b/drivers/usb/host/ehci-hcd.c Tue May 13 16:50:22 2003
@@ -31,6 +31,7 @@
#include <linux/list.h>
#include <linux/interrupt.h>
#include <linux/reboot.h>
+#include <linux/bitops.h> /* for generic_ffs */
#ifdef CONFIG_USB_DEBUG
#define DEBUG
--
Richard \\\ SuperH Core+Debug Architect /// .. At home ..
P. /// richard.curnow@superh.com /// rc@rc0.org.uk
Curnow \\\ http://www.superh.com/ /// www.rc0.org.uk
Speaking for myself, not on behalf of SuperH
next reply other threads:[~2003-05-13 15:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-13 15:53 Richard Curnow [this message]
2003-05-13 20:39 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030513155341.GB1609@malvern.uk.w2k.superh.com \
--to=richard.curnow@superh.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®