From: Christopher Hoover <ch@murgatroid.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-kernel@vger.kernel.org, torvalds@transmeta.com, ch@murgatroid.com
Subject: Re: [PATCH] 2.5.68: Don't include SCSI block ioctls on non-scsi systems
Date: Wed, 14 May 2003 01:08:02 -0700 [thread overview]
Message-ID: <20030514010801.A4080@heavens.murgatroid.com> (raw)
In-Reply-To: <20030514065752.A647@infradead.org>; from hch@infradead.org on Wed, May 14, 2003 at 06:57:52AM +0100
On Wed, May 14, 2003 at 06:57:52AM +0100, Christoph Hellwig wrote:
> On Tue, May 13, 2003 at 08:29:20PM -0700, Christopher Hoover wrote:
> > Unless I'm missing something, there doesn't seem to be a good reason
> > for the block system to include SCSI ioctls unless there's a SCSI
> > block device (CONFIG_BLK_DEV_SD) in the system.
>
> That's broken. You can use them on ide, sd and sr currently.
OK, let's try that again.
diff -X /home/ch/src/dontdiff.txt -Naurp linux-2.5.69.orig/drivers/block/Kconfig linux-2.5.69/drivers/block/Kconfig
--- linux-2.5.69.orig/drivers/block/Kconfig 2003-05-04 16:53:08.000000000 -0700
+++ linux-2.5.69/drivers/block/Kconfig 2003-05-14 00:58:36.000000000 -0700
@@ -348,3 +348,6 @@ config LBD
endmenu
+config SCSI_IOCTL
+ bool
+ default y if IDE||SCSI
diff -X /home/ch/src/dontdiff.txt -Naurp linux-2.5.69.orig/drivers/block/Makefile linux-2.5.69/drivers/block/Makefile
--- linux-2.5.69.orig/drivers/block/Makefile 2003-05-04 16:53:37.000000000 -0700
+++ linux-2.5.69/drivers/block/Makefile 2003-05-14 00:58:50.000000000 -0700
@@ -8,7 +8,9 @@
# In the future, some of these should be built conditionally.
#
-obj-y := elevator.o ll_rw_blk.o ioctl.o genhd.o scsi_ioctl.o deadline-iosched.o
+obj-y := elevator.o ll_rw_blk.o ioctl.o genhd.o deadline-iosched.o
+
+obj-$(CONFIG_SCSI_IOCTL) += scsi_ioctl.o
obj-$(CONFIG_MAC_FLOPPY) += swim3.o
obj-$(CONFIG_BLK_DEV_FD) += floppy.o
next prev parent reply other threads:[~2003-05-14 7:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-14 3:29 Christopher Hoover
2003-05-14 5:57 ` Christoph Hellwig
2003-05-14 6:05 ` Christopher Hoover
2003-05-14 8:08 ` Christopher Hoover [this message]
2003-05-14 8:10 ` Christoph Hellwig
2003-05-14 8:12 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030514010801.A4080@heavens.murgatroid.com \
--to=ch@murgatroid.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®