From: Andi Kleen <ak@suse.de>
To: john stultz <johnstul@us.ibm.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@digeo.com>,
"Martin J. Bligh" <mbligh@aracnet.com>, Andi Kleen <ak@suse.de>
Subject: Re: [PATCH] linux-2.5.69_subarch-fix_A0.patch
Date: Thu, 15 May 2003 08:51:20 +0200 [thread overview]
Message-ID: <20030515065120.GA3469@Wotan.suse.de> (raw)
In-Reply-To: <1052966228.9630.69.camel@w-jstultz2.beaverton.ibm.com>
On Wed, May 14, 2003 at 07:37:09PM -0700, john stultz wrote:
> All,
> This patch fixes a circular dependency (a function in mach_apic.h
> requires hard_smp_processor_id() and hard_smp_processor_id() requires
> macros from mach_apic.h) that has been in the subarch code for a bit,
> but was hacked around with some #ifdefs.
>
> With the inclusion of the generic-subarch the hack was dropped and
> bigsmp and summit promptly broke. So this makes things compile again.
What broke exactly? I thought worked around this problem for the generic
subarchitecture.
Accessing the APIC directly this way just to work around a bad include
looks quite ugly to me.
-Andi
next prev parent reply other threads:[~2003-05-15 6:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-15 2:37 john stultz
2003-05-15 6:51 ` Andi Kleen [this message]
2003-05-15 17:20 ` john stultz
2003-05-15 17:28 ` Andi Kleen
2003-05-15 17:46 ` john stultz
2003-05-15 19:00 ` Andi Kleen
2003-05-15 19:19 ` William Lee Irwin III
2003-05-15 17:17 ` Martin J. Bligh
2003-05-15 19:50 ` Andi Kleen
2003-05-15 19:55 ` William Lee Irwin III
2003-05-15 17:45 ` Martin J. Bligh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030515065120.GA3469@Wotan.suse.de \
--to=ak@suse.de \
--cc=akpm@digeo.com \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mbligh@aracnet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®