From: Sam Ravnborg <sam@ravnborg.org>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: reiserfs-dev@namesys.com, linux-kernel@vger.kernel.org
Subject: [PATCH] Remove 'strchr' warning from reiserfs
Date: Sat, 17 May 2003 21:16:11 +0200 [thread overview]
Message-ID: <20030517191611.GA10417@mars.ravnborg.org> (raw)
Hi Linus, please apply - maintainer cc:ed for info.
Reiserfs emits a warning about strchr being defined but not
used. I finally tracked down the reason for this.
gcc - when seeing strstr(x, "%") recognized that the second parameter
is a char, and therefore uses strchr instead of strstr.
The workaround to avoid the warning is to replace the call
to strstr with strchr - which is OK.
This hides the warning, and brings us down to 6 warnings for a
make defconfig bzImage.
Sam
===== fs/reiserfs/prints.c 1.21 vs edited =====
--- 1.21/fs/reiserfs/prints.c Sun Mar 23 07:14:13 2003
+++ edited/fs/reiserfs/prints.c Sat May 17 21:08:16 2003
@@ -164,7 +164,7 @@
*skip = 0;
- while ((k = strstr (k, "%")) != NULL)
+ while ((k = strchr (k, '%')) != NULL)
{
if (k[1] == 'k' || k[1] == 'K' || k[1] == 'h' || k[1] == 't' ||
k[1] == 'z' || k[1] == 'b' || k[1] == 'y' || k[1] == 'a' ) {
next reply other threads:[~2003-05-17 19:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-17 19:16 Sam Ravnborg [this message]
2003-05-19 19:47 ` Stephen Hemminger
2003-05-19 21:33 ` Sam Ravnborg
2003-05-20 0:26 ` Kurt Wall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030517191611.GA10417@mars.ravnborg.org \
--to=sam@ravnborg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=reiserfs-dev@namesys.com \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®