Hi, There is some new stuff: ----------------------- - 'struct device *device' is used instead of 'char *device'. So we now have the device symlink :) - request_firmware_nowait is implemented, please comment on it. - It doesn't abuse the stack any more, or at least not that much :) - There is a timeout, changeable from userspace. Feedback on a reasonable default value appreciated. - Extended 'loading' semantics: echo 1 > loading: start a new load, and flush any data from a previous partial load. echo 0 > loading: finish load. echo -1 > loading: cancel load and give an error to the driver. - adapted to new sysfs interface. - it is now a patch against current bk-cvs gateway. - There is a *working* sample on how to use the firmware class without using request_firmware(). It is not clean, but it works, if it is found to be interesting it should be further polished. Some random notes: ----------------- - request_firmware_cancel is not needed, request_firmware_nowait will lock the client module into memory until after triggering the callback. The only other problem that I can think of is the device getting unplugged while waiting for firmware, so the driver callback should first make sure that the device is still there. - firmware-class.diff adds both samples to the kernel tree, that doesn't mean that I want them there, it is just for easier testing. Patches: ------- - firmware-class.diff: firmware_class code and the two samples. - sysfs-bin-flexible-size.diff: Make dynamically sized files possible. And return the right value on successful write. - sysfs-bin-lost-dget.diff: I was having trouble when calling request_firmware() from a work queue, and after a little investigations it seams that this dget got lost along the way. Adding it back fixed the issue. Or am I causing a dentry leak now? PS: If you guys consider this abusive CC:ing, please complain. -- --- Manuel Estrada Sainz ------------------------ ------------------- Let us have the serenity to accept the things we cannot change, courage to change the things we can, and wisdom to know the difference.