From: Christoph Hellwig <hch@infradead.org>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Corey Minyard <cminyard@mvista.com>,
linux.nics@intel.com, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Add boot command line parsing for the e100 driver
Date: Mon, 19 May 2003 17:33:23 +0100 [thread overview]
Message-ID: <20030519173323.A22670@infradead.org> (raw)
In-Reply-To: <20030519163052.GB17048@gtf.org>; from jgarzik@pobox.com on Mon, May 19, 2003 at 12:30:52PM -0400
On Mon, May 19, 2003 at 12:30:52PM -0400, Jeff Garzik wrote:
> >
> > Don't do this. 2.5 has the module_parame stuff that works for both
> > static and modular drivers. Just convert e100 to it.
>
> ...which totally screws people trying to keep 2.4 and 2.5
> sources as close as possible.
So what? It's not that we APIs don't change under Linux.
> If all modules do not require new module_param changes, then logically,
> e100 does not either. And e100 has a better argument than most against
> such changes.
Again, we don't convert old drivers just for the sake of it. But
instead of adding such horrible cruft Corey did it should just use the
proper API.
next prev parent reply other threads:[~2003-05-19 16:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-19 16:09 Corey Minyard
2003-05-19 16:17 ` Christoph Hellwig
2003-05-19 16:30 ` Jeff Garzik
2003-05-19 16:33 ` Christoph Hellwig [this message]
2003-05-19 16:40 ` Jeff Garzik
2003-05-19 17:04 ` Corey Minyard
2003-05-20 0:16 ` Bartlomiej Zolnierkiewicz
2003-05-20 0:44 ` Bartlomiej Zolnierkiewicz
2003-05-20 1:30 ` Corey Minyard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030519173323.A22670@infradead.org \
--to=hch@infradead.org \
--cc=cminyard@mvista.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux.nics@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®