From: Pavel Machek <pavel@ucw.cz>
To: Milton Miller <miltonm@kb5tkf.karlin.mff.cuni.cz>
Cc: linux-kernel@vger.kernel.org
Subject: Re: ioctl32 cleanups: kill code duplication
Date: Mon, 19 May 2003 21:16:25 +0200 [thread overview]
Message-ID: <20030519191625.GA479@elf.ucw.cz> (raw)
In-Reply-To: <200305190135.h4J1ZGR31059@kb5tkf>
[-- Attachment #1: Type: text/plain, Size: 578 bytes --]
Hi!
> > +#include "../../../fs/compat_ioctl.c"
>
> I think the kbuild people would rather you do this in the Makefile with
> something like
>
> CFLAGS_ioctl32.o += -Ifs/
>
> and then
>
> #include "compat_ioctl.c"
>
> instead. I know the seperate source/obj dir people will.
Applied, thanx. [Milton, you have some severe misconfiguration in your
mail system... watch your from address.]
Patch now looks like [attached]. If there are no protests I'll send it
to Linus.
Pavel
--
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]
[-- Attachment #2: delme.gz --]
[-- Type: application/octet-stream, Size: 50473 bytes --]
next prev parent reply other threads:[~2003-05-19 19:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-19 1:35 Milton Miller
2003-05-19 19:16 ` Pavel Machek [this message]
-- strict thread matches above, loose matches on Subject: below --
2003-05-18 22:17 Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030519191625.GA479@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=miltonm@kb5tkf.karlin.mff.cuni.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®