From: Duncan Sands <baldrick@wanadoo.fr>
To: linux-usb-devel@lists.sourceforge.net
Cc: Greg KH <greg@kroah.com>, linux-kernel@vger.kernel.org
Subject: [PATCH 12/14] USB speedtouch: remove useless NULL pointer checks
Date: Wed, 21 May 2003 01:05:06 +0200 [thread overview]
Message-ID: <200305210105.06006.baldrick@wanadoo.fr> (raw)
The stats field is never NULL.
speedtch.c | 12 ++++--------
1 files changed, 4 insertions(+), 8 deletions(-)
diff -Nru a/drivers/usb/misc/speedtch.c b/drivers/usb/misc/speedtch.c
--- a/drivers/usb/misc/speedtch.c Wed May 21 00:41:05 2003
+++ b/drivers/usb/misc/speedtch.c Wed May 21 00:41:05 2003
@@ -358,8 +358,7 @@
/* is skb long enough ? */
if (skb->len < pdu_length) {
- if (ctx->vcc->stats)
- atomic_inc (&ctx->vcc->stats->rx_err);
+ atomic_inc (&ctx->vcc->stats->rx_err);
return NULL;
}
@@ -378,8 +377,7 @@
/* check crc */
if (pdu_crc != crc) {
dbg ("udsl_decode_aal5: crc check failed!");
- if (ctx->vcc->stats)
- atomic_inc (&ctx->vcc->stats->rx_err);
+ atomic_inc (&ctx->vcc->stats->rx_err);
return NULL;
}
@@ -387,8 +385,7 @@
skb_trim (skb, length);
/* update stats */
- if (ctx->vcc->stats)
- atomic_inc (&ctx->vcc->stats->rx);
+ atomic_inc (&ctx->vcc->stats->rx);
vdbg ("udsl_decode_aal5 returns pdu 0x%p with length %d", skb, skb->len);
return skb;
@@ -760,8 +757,7 @@
dev_kfree_skb (skb);
instance->current_skb = NULL;
- if (vcc->stats)
- atomic_inc (&vcc->stats->tx);
+ atomic_inc (&vcc->stats->tx);
}
goto made_progress;
reply other threads:[~2003-05-20 22:54 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200305210105.06006.baldrick@wanadoo.fr \
--to=baldrick@wanadoo.fr \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®