Re: request_firmware() hotplug interface, third round and a halve

[Manuel Estrada Sainz <ranty@debian.org>]

On Wed, May 21, 2003 at 05:44:56PM +1000, David Gibson wrote:
> On Wed, May 21, 2003 at 12:23:18AM -0700, Greg Kroah-Hartman wrote:
> > > +struct firmware_priv {
> > > +	char fw_id[FIRMWARE_NAME_MAX];
> > > +	struct completion completion;
> > > +	struct bin_attribute attr_data;
> > > +	struct firmware *fw;
> > > +	s32 loading:2;
> > > +	u32 abort:1;
> > 
> > Why s32 and u32?  Why not just ints for both of them?
> 
> And for that matter, I don't think there's any point using bitfields,
> 61 bits is not worth it.

 Done, I just sent updated patches.

 Thanks

 	Manuel

-- 
--- Manuel Estrada Sainz <ranty@debian.org>
                         <ranty@bigfoot.com>
			 <ranty@users.sourceforge.net>
------------------------ <manuel.estrada@hispalinux.es> -------------------
Let us have the serenity to accept the things we cannot change, courage to
change the things we can, and wisdom to know the difference.