From: "YOSHIFUJI Hideaki / 吉藤英明" <yoshfuji@linux-ipv6.org>
To: kde@myrealbox.com
Cc: thunder7@xs4all.nl, linux-kernel@vger.kernel.org
Subject: Re: bk15 build fails with modular apm (undefined reference to MODULE_OWNER)
Date: Thu, 22 May 2003 19:02:43 +0900 (JST) [thread overview]
Message-ID: <20030522.190243.36013922.yoshfuji@linux-ipv6.org> (raw)
In-Reply-To: <1053592419.b2fa6d60kde@myrealbox.com>
In article <1053592419.b2fa6d60kde@myrealbox.com> (at Thu, 22 May 2003 02:33:39 -0600), "ismail donmez" <kde@myrealbox.com> says:
> Adding
> #define SET_MODULE_OWNER(apm_proc) do { } while (0)
> to arch/i386/kernel/apm.c fixes this.
:
> > arch/i386/kernel/built-in.o(.init.text+0x5744): In function `apm_init':
> > : undefined reference to `SET_MODULE_OWNER'
> > make: *** [.tmp_vmlinux1] Error 1
> > :
> >
> > Is SET_MODULE_OWNER needed or not?
I believe we should set apm_proc->owner here.
Index: linux25-LINUS/arch/i386/kernel/apm.c
===================================================================
RCS file: /cvsroot/usagi/usagi-backport/linux25/arch/i386/kernel/apm.c,v
retrieving revision 1.1.1.12
diff -u -r1.1.1.12 apm.c
--- linux25-LINUS/arch/i386/kernel/apm.c 15 May 2003 07:52:06 -0000 1.1.1.12
+++ linux25-LINUS/arch/i386/kernel/apm.c 22 May 2003 09:22:04 -0000
@@ -2013,7 +2013,7 @@
apm_proc = create_proc_info_entry("apm", 0, NULL, apm_get_info);
if (apm_proc)
- SET_MODULE_OWNER(apm_proc);
+ apm_proc->owner = THIS_MODULE;
kernel_thread(apm, NULL, CLONE_FS | CLONE_FILES | CLONE_SIGHAND | SIGCHLD);
--
Hideaki YOSHIFUJI @ USAGI Project <yoshfuji@linux-ipv6.org>
GPG FP: 9022 65EB 1ECF 3AD1 0BDF 80D8 4807 F894 E062 0EEA
next prev parent reply other threads:[~2003-05-22 9:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-22 8:33 ismail donmez
2003-05-22 10:02 ` YOSHIFUJI Hideaki / 吉藤英明 [this message]
-- strict thread matches above, loose matches on Subject: below --
2003-05-22 6:47 Jurriaan
2003-05-22 7:41 ` Jurriaan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030522.190243.36013922.yoshfuji@linux-ipv6.org \
--to=yoshfuji@linux-ipv6.org \
--cc=kde@myrealbox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=thunder7@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®