mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@digeo.com>
To: maneesh@in.ibm.com, Jens Axboe <axboe@suse.de>
Cc: ivg2@cornell.edu, linux-kernel@vger.kernel.org,
	page0588@sundance.sjsu.edu, greg@kroah.com, tytso@us.ibm.com
Subject: Re: kernel BUG at include/linux/dcache.h:271!
Date: Thu, 22 May 2003 15:19:54 -0700	[thread overview]
Message-ID: <20030522151954.1230ef53.akpm@digeo.com> (raw)
In-Reply-To: <20030522115702.GA1150@in.ibm.com>

Maneesh Soni <maneesh@in.ibm.com> wrote:
>
> The problem is that we have multiple ramdisks but all have
> common request queue and common elevator. In terms of sysfs we 
> have multiple kobjects for multiple ramdisks, but one single kobject for the 
> ramdisks' common elevator. 
> 
> While initializing, different kobjects are allocated for the ramdisks but,
> the common elevator uses the same kobject. In other words, every init
> of a ramdisk, the common elevator.kobj->parent will be different and it will
> allocate a new dentry, overwrite the elevator.kobj->dentry
> and loose the earlier allocated dentries. (see: elv_register_queue())
> 
> While exiting, it ends up in removing the same dentry (allocated at the last)
> again and BUGs in dget on dentry with zero ref count.
> 
> Not sure where it should be fixed 
> ramdisk 
>  - should have separate queues on for each ramdisk
> 
> elevator 
>  - should not re-register already registered queue in elv_register_queue
> 
> sysfs 
>  - should handle kobject with multiple parent kobjects 

I can't think of anywhere else where we are likely to want to support
multiple devices from a single queue in this manner, so perhaps the best
solution is to remove the exceptional case: allocate a separate queue for
each ramdisk instance.

Jens, do you agree?



  reply	other threads:[~2003-05-22 22:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-05-21 23:11 Ivan Gyurdiev
2003-05-22 11:57 ` Maneesh Soni
2003-05-22 22:19   ` Andrew Morton [this message]
2003-05-23  6:25     ` Jens Axboe
2003-05-23 12:43       ` Maneesh Soni
2003-05-23 12:55         ` Maneesh Soni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030522151954.1230ef53.akpm@digeo.com \
    --to=akpm@digeo.com \
    --cc=axboe@suse.de \
    --cc=greg@kroah.com \
    --cc=ivg2@cornell.edu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maneesh@in.ibm.com \
    --cc=page0588@sundance.sjsu.edu \
    --cc=tytso@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®