From: William Lee Irwin III <wli@holomorphy.com>
To: mikpe@csd.uu.se
Cc: akpm@digeo.com, linux-kernel@vger.kernel.org
Subject: Re: arch/i386/kernel/mpparse.c warning fixes
Date: Thu, 22 May 2003 09:23:05 -0700 [thread overview]
Message-ID: <20030522162305.GT8978@holomorphy.com> (raw)
In-Reply-To: <16076.62927.525714.113342@gargle.gargle.HOWL>
William Lee Irwin III writes:
>> - if (m->mpc_apicid > MAX_APICS) {
>> + if (MAX_APICS - m->mpc_apicid <= 0) {
>> printk(KERN_WARNING "Processor #%d INVALID. (Max ID: %d).\n",
>> m->mpc_apicid, MAX_APICS);
>> --num_processors;
On Thu, May 22, 2003 at 06:07:43PM +0200, mikpe@csd.uu.se wrote:
> Eeew. Whatever the original problem is, this "fix" is just too
> obscure and ugly.
m->mpc_apicid is an 8-bit type; MAX_APICS can be 256. The above fix
properly compares two integral expressions of equal width.
Also, as MAX_APICS-1 is reserved for the broadcast physical APIC ID
(it's 0xF for serial APIC and 0xFF for xAPIC) the small semantic change
here is correct.
-- wli
next prev parent reply other threads:[~2003-05-22 16:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-22 15:53 William Lee Irwin III
2003-05-22 16:07 ` mikpe
2003-05-22 16:23 ` William Lee Irwin III [this message]
2003-05-22 18:29 ` mikpe
2003-05-22 18:36 ` William Lee Irwin III
2003-05-22 18:49 ` mikpe
2003-05-22 18:59 ` William Lee Irwin III
2003-05-22 19:03 ` mikpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030522162305.GT8978@holomorphy.com \
--to=wli@holomorphy.com \
--cc=akpm@digeo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mikpe@csd.uu.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®