mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Schlichter <schlicht@uni-mannheim.de>
To: "David S. Miller" <davem@redhat.com>
Cc: akpm@digeo.com, mfc@krycek.org, linux-kernel@vger.kernel.org
Subject: Re: Error during compile of 2.5.69-mm8
Date: Fri, 23 May 2003 01:47:00 +0200	[thread overview]
Message-ID: <200305230147.00730.schlicht@uni-mannheim.de> (raw)
In-Reply-To: <20030522.162913.115921853.davem@redhat.com>

[-- Attachment #1: signed data --]
[-- Type: text/plain, Size: 1160 bytes --]

On May 23, David S. Miller wrote:
>    From: Thomas Schlichter <schlicht@uni-mannheim.de>
>    Date: Fri, 23 May 2003 01:28:06 +0200
>
>    On May 23, David S. Miller wrote:
>    > Yoshfuji posted a patch on linux-kernel to fix this already.
>
>    Sorry, I must have missed this patch - that would have made my work
>    obsolete -
>    but I'd like to see how that supports all the other
>    SET_MODULE_OWNER calls from all the other places...
>
> They also should be converted to explicit ->owner references.

Well, I don't think so...
I don't like it if there is a possibility doing it with an initializer, but in 
other cases it may increase readability, too...

There was a discussion about SET_MODULE_OWNER here on the list, once.
You can find it here:

     http://marc.theaimsgroup.com/?t=104969843600002&r=1&w=2

At the end Rusty made a small patch that never made it into the mainline tree 
(even if I think it should have...) His mail with the patch can be found at:

     http://marc.theaimsgroup.com/?l=linux-kernel&m=105065084724249&w=2

(I like the analogy to a mainframe ;-)

Best regards
   Thomas Schlichter

[-- Attachment #2: signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

  reply	other threads:[~2003-05-22 23:34 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-05-22 13:54 Mads Christensen
2003-05-22 15:29 ` Mads Christensen
2003-05-22 23:10   ` Thomas Schlichter
     [not found] ` <20030522160218.57b828db.akpm@digeo.com>
2003-05-22 23:05   ` David S. Miller
2003-05-22 23:28     ` Thomas Schlichter
2003-05-22 23:29       ` David S. Miller
2003-05-22 23:47         ` Thomas Schlichter [this message]
2003-05-22 23:48           ` David S. Miller
2003-05-23  0:13             ` Thomas Schlichter
2003-05-23  0:23               ` David S. Miller
2003-05-23  1:06                 ` Thomas Schlichter
2003-05-23  1:16                   ` David S. Miller
     [not found] <200305230327.57985.schlicht@uni-mannheim.de>
     [not found] ` <200305230538.38946.schlicht@uni-mannheim.de>
     [not found]   ` <20030522.213217.27796203.davem@redhat.com>
2003-05-24 14:36     ` Thomas Schlichter
2003-05-26  2:18       ` David S. Miller
2003-05-26  6:35         ` Thomas Schlichter
2003-05-26  7:04           ` David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200305230147.00730.schlicht@uni-mannheim.de \
    --to=schlicht@uni-mannheim.de \
    --cc=akpm@digeo.com \
    --cc=davem@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mfc@krycek.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®