From: Christoph Hellwig <hch@lst.de>
To: torvalds@transmeta.com
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] make vt_ioctl ix86isms explicit
Date: Sat, 24 May 2003 19:37:13 +0200 [thread overview]
Message-ID: <20030524173713.GA4939@lst.de> (raw)
sys_ioperm is only implemented on x86 (i386/x86_64). Make the
ifdefs in vt_ioctl.c more explicit so the other architectures can
get rid of their stubs in favour of just using sys_ni_syscall in
the syscall table. (Personally I still wonder why they added it
at all but that's another question..)
--- 1.23/drivers/char/vt_ioctl.c Mon May 12 16:12:47 2003
+++ edited/drivers/char/vt_ioctl.c Fri May 23 21:27:46 2003
@@ -59,7 +59,7 @@
*/
unsigned char keyboard_type = KB_101;
-#if !defined(__alpha__) && !defined(__ia64__) && !defined(__mips__) && !defined(__arm__) && !defined(__sh__)
+#ifdef CONFIG_X86
asmlinkage long sys_ioperm(unsigned long from, unsigned long num, int on);
#endif
@@ -424,11 +424,13 @@
ucval = keyboard_type;
goto setchar;
-#if !defined(__alpha__) && !defined(__ia64__) && !defined(__mips__) && !defined(__arm__) && !defined(__sh__)
/*
* These cannot be implemented on any machine that implements
- * ioperm() in user level (such as Alpha PCs).
+ * ioperm() in user level (such as Alpha PCs) or not at all.
+ *
+ * XXX: you should never use these, just call ioperm directly..
*/
+#ifdef CONFIG_X86
case KDADDIO:
case KDDELIO:
/*
next reply other threads:[~2003-05-24 17:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-24 17:37 Christoph Hellwig [this message]
2003-05-24 17:55 ` Linus Torvalds
2003-05-24 18:03 ` Christoph Hellwig
2003-05-24 22:16 ` Andries Brouwer
2003-05-24 18:03 ` James Simmons
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030524173713.GA4939@lst.de \
--to=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®