From: Andi Kleen <ak@suse.de>
To: "Grover, Andrew" <andrew.grover@intel.com>
Cc: Andi Kleen <ak@suse.de>,
torvalds@transmeta.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Make ACPI compile again on 64bit/gcc 3.3
Date: Sun, 25 May 2003 00:19:33 +0200 [thread overview]
Message-ID: <20030524221933.GA22506@wotan.suse.de> (raw)
In-Reply-To: <F760B14C9561B941B89469F59BA3A847E96ED2@orsmsx401.jf.intel.com>
On Sat, May 24, 2003 at 01:55:26PM -0700, Grover, Andrew wrote:
> Actually, I think osl.c should be changed to match the header as it
> stands. Could you try that and see if that also fixes things?
Yes it does of course.
BTW FYI these are the warnings I see in ACPI when compiling with gcc 3.3 for
64bit:
drivers/acpi/processor.c: In function `acpi_processor_add_fs':
drivers/acpi/processor.c:1518: warning: assignment from incompatible pointer typ e
drivers/acpi/processor.c:1531: warning: assignment from incompatible pointer typ e
drivers/acpi/thermal.c:187: warning: initialization from incompatible pointer ty pe
drivers/acpi/thermal.c:195: warning: initialization from incompatible pointer ty poe
drivers/acpi/thermal.c:203: warning: initialization from incompatible pointer type
drivers/acpi/utils.c: In function `acpi_evaluate_reference':
drivers/acpi/utils.c:351: warning: unsigned int format, different type arg (arg
5)
-Andi
Index: linux/drivers/acpi/osl.c
===================================================================
RCS file: /home/cvs/linux-2.5/drivers/acpi/osl.c,v
retrieving revision 1.27
diff -u -u -r1.27 osl.c
--- linux/drivers/acpi/osl.c 24 May 2003 01:49:28 -0000 1.27
+++ linux/drivers/acpi/osl.c 24 May 2003 21:12:05 -0000
@@ -952,14 +952,14 @@
* We just have to assume we're dealing with valid memory
*/
-BOOLEAN
-acpi_os_readable(void *ptr, u32 len)
+u8
+acpi_os_readable(void *ptr, acpi_size len)
{
return 1;
}
-BOOLEAN
-acpi_os_writable(void *ptr, u32 len)
+u8
+acpi_os_writable(void *ptr, acpi_size len)
{
return 1;
}
>
next prev parent reply other threads:[~2003-05-24 22:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-24 20:55 Grover, Andrew
2003-05-24 22:19 ` Andi Kleen [this message]
2003-05-24 22:39 ` [PATCH] Make ACPI compile again on 64bit/gcc 3.3 II Andi Kleen
-- strict thread matches above, loose matches on Subject: below --
2003-05-24 8:39 [PATCH] Make ACPI compile again on 64bit/gcc 3.3 Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030524221933.GA22506@wotan.suse.de \
--to=ak@suse.de \
--cc=andrew.grover@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®