From: Marc-Christian Petersen <m.c.p@wolk-project.de>
To: Marcelo Tosatti <marcelo@conectiva.com.br>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 2.4.21-rc4] Fix oom killer braindamage
Date: Tue, 27 May 2003 21:05:45 +0200 [thread overview]
Message-ID: <200305272104.05802.m.c.p@wolk-project.de> (raw)
[-- Attachment #1: Type: text/plain, Size: 487 bytes --]
Hi Marcelo,
attached patch fixes the oom killer braindamage where it tries to kill
processes again and again and again w/o any ending or successfull killing of
the selected processes in an OOM case.
The attached, very simple but effective, patch fixes it.
All the kudos go to Rik van Riel.
Patch tested and works, and also for a long time in my tree (and maybe also
others?!)
This issue is out there for several years.
Please consider it for 2.4.21-rc5, thanks.
ciao, Marc
[-- Attachment #2: oomkiller-braindamage-fix.patch --]
[-- Type: text/x-diff, Size: 417 bytes --]
===== mm/oom_kill.c 1.11 vs edited =====
--- 1.11/mm/oom_kill.c Fri Aug 16 10:59:46 2002
+++ edited/mm/oom_kill.c Sat Feb 22 17:31:49 2003
@@ -61,11 +61,16 @@ static int badness(struct task_struct *p
if (!p->mm)
return 0;
+
+ if (p->flags & PF_MEMDIE)
+ return 0;
+
/*
* Never kill init
*/
if (p->pid == 1)
return 0;
+
/*
* The memory size of the process is the basis for the badness.
*/
next reply other threads:[~2003-05-27 18:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-27 19:05 Marc-Christian Petersen [this message]
2003-05-27 19:12 ` Marcelo Tosatti
2003-05-27 19:18 ` Marc-Christian Petersen
2003-05-27 19:28 ` Marc-Christian Petersen
2003-05-27 19:31 ` Marcelo Tosatti
2003-05-28 22:14 ` Pavel Machek
2003-05-27 19:31 ` Marc-Christian Petersen
2003-05-27 19:34 ` Marcelo Tosatti
2003-05-27 19:46 ` Marc-Christian Petersen
2003-05-27 19:34 ` Jens Axboe
2003-05-27 19:20 ` William Lee Irwin III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200305272104.05802.m.c.p@wolk-project.de \
--to=m.c.p@wolk-project.de \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®