From: Andi Kleen <ak@suse.de>
To: "David S. Miller" <davem@redhat.com>
Cc: ak@suse.de, pavel@suse.cz, akpm@digeo.com, linux-kernel@vger.kernel.org
Subject: Re: must-fix list, v5
Date: Thu, 29 May 2003 11:46:48 +0200 [thread overview]
Message-ID: <20030529094648.GB15333@wotan.suse.de> (raw)
In-Reply-To: <20030529.023203.41634240.davem@redhat.com>
On Thu, May 29, 2003 at 02:32:03AM -0700, David S. Miller wrote:
> From: Andi Kleen <ak@suse.de>
> Date: 29 May 2003 11:17:36 +0200
>
> This part won't work on sparc64 because it has separate address spaces
> for user/kernel.
>
> Yes, in fact I happen to be working in this area hold on...
>
> I'm redoing Andi's x86_64 ioctl32 bug fixes more cleanly
> for sparc64 by instead using alloc_user_space().
>
> Sorry Andi, I just couldn't bring myself to allow those bogus
> artificial limits you added just to fix these bugs... :-)
I also didn't like them too much and where they looked like they could
hurt I resorted to the verify_area trick instead (which didn't work
for you...)
I believe the remaining limits are harmless, but of course it's cleaner
to not have them.
If you use the function that extensively it would be better to allow
it to nest (e.g. add a field for the current offset in task struct).
Otherwise someone will get it wrong sooner or later.
(like the sock/tw_bucket ;)
> This work also pointed out many bugs in this area which should
> be fixed by my stuff. (CDROMREAD* ioctls don't take struct cdrom_read
> they take struct cdrom_msf which is compatible, struct
> cdrom_generic_command32 was missing some members, etc. etc.)
>
> This is a 2.4.x patch but should be easy to push over to the 2.5.x
> ioctl stuff using the appropriate compat types.
Ok thanks. I will port it to my 2.4 code.
Did you test them all?
-Andi
next prev parent reply other threads:[~2003-05-29 9:33 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20030521152255.4aa32fba.akpm@digeo.com.suse.lists.linux.kernel>
[not found] ` <20030521152334.4b04c5c9.akpm@digeo.com.suse.lists.linux.kernel>
[not found] ` <20030526093717.GC642@zaurus.ucw.cz.suse.lists.linux.kernel>
[not found] ` <20030528144839.47efdc4f.akpm@digeo.com.suse.lists.linux.kernel>
[not found] ` <20030528215551.GB255@elf.ucw.cz.suse.lists.linux.kernel>
2003-05-29 9:17 ` Andi Kleen
2003-05-29 9:32 ` David S. Miller
2003-05-29 9:46 ` Pavel Machek
2003-05-29 10:01 ` David S. Miller
2003-05-29 10:03 ` Pavel Machek
2003-05-29 9:46 ` Andi Kleen [this message]
2003-05-29 10:01 ` David S. Miller
2003-05-29 11:25 ` Pavel Machek
2003-05-29 11:26 ` David S. Miller
2003-05-29 11:39 ` Arjan van de Ven
2003-05-29 20:10 ` Pavel Machek
2003-05-29 20:06 ` Pavel Machek
2003-05-29 21:15 ` David S. Miller
2003-05-22 8:16 Grover, Andrew
2003-05-22 8:31 ` Andrew Morton
2003-05-22 14:23 ` Jos Hulzink
-- strict thread matches above, loose matches on Subject: below --
2003-05-21 23:59 Arnd Bergmann
2003-05-21 22:22 Andrew Morton
2003-05-21 22:23 ` Andrew Morton
2003-05-21 22:49 ` Tom Rini
2003-05-21 22:55 ` Andrew Morton
2003-05-26 9:37 ` Pavel Machek
2003-05-28 21:48 ` Andrew Morton
2003-05-28 21:55 ` Pavel Machek
2003-05-28 22:06 ` Andrew Morton
[not found] ` <20030528221812.GC255@elf.ucw.cz>
2003-05-28 22:46 ` Andrew Morton
2003-05-28 23:03 ` Pavel Machek
2003-05-29 11:13 ` Pavel Machek
2003-05-21 22:41 ` Andrew Morton
2003-05-22 1:03 ` Carl-Daniel Hailfinger
2003-05-22 3:08 ` oxymoron
2003-05-22 1:25 ` Andrew Theurer
2003-05-22 6:24 ` Jens Axboe
2003-05-25 21:05 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030529094648.GB15333@wotan.suse.de \
--to=ak@suse.de \
--cc=akpm@digeo.com \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®