From: Daniel Ritz <daniel.ritz@gmx.ch>
To: "linux-kernel" <linux-kernel@vger.kernel.org>, feketga@delfin.klte.hu
Subject: Re: [Bug 762] New: cs4232, cs4236 module loading problem
Date: Sun, 1 Jun 2003 18:56:34 +0200 [thread overview]
Message-ID: <200306011856.34369.daniel.ritz@gmx.ch> (raw)
yaroslav's linux-sound tree has two fixes to cs4236.c, i think they fix the
reported oops.
rgds
-daniel
--- 1.14/sound/isa/cs423x/cs4236.c Thu Apr 10 03:28:11 2003
+++ 1.15/sound/isa/cs423x/cs4236.c Fri Apr 11 04:37:55 2003
@@ -590,6 +590,9 @@
cards += pnp_register_card_driver(&cs423x_pnpc_driver);
#endif
if (!cards) {
+#ifdef CONFIG_PNP
+ pnp_unregister_card_driver(&cs423x_pnpc_driver);
+#endif
#ifdef MODULE
printk(KERN_ERR IDENT " soundcard not found or device busy\n");
#endif
--- 1.15/sound/isa/cs423x/cs4236.c Fri Apr 11 04:37:55 2003
+++ 1.16/sound/isa/cs423x/cs4236.c Tue May 20 14:13:00 2003
@@ -365,7 +365,6 @@
snd_printk(KERN_ERR IDENT " MPU401 PnP manual resources are invalid, using auto config\n");
err = pnp_activate_dev(pdev);
if (err < 0) {
- kfree(cfg);
printk(KERN_ERR IDENT " MPU401 PnP configure failed for WSS (out of resources?)\n");
mpu_port[dev] = SNDRV_AUTO_PORT;
mpu_irq[dev] = SNDRV_AUTO_IRQ;
@@ -382,7 +381,7 @@
kfree(cfg);
return 0;
}
-#endif
+#endif /* CONFIG_PNP */
static void snd_card_cs4236_free(snd_card_t *card)
{
next reply other threads:[~2003-06-01 16:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-01 16:56 Daniel Ritz [this message]
2003-06-02 18:59 ` Fekete Gabor
-- strict thread matches above, loose matches on Subject: below --
2003-06-01 15:11 Martin J. Bligh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200306011856.34369.daniel.ritz@gmx.ch \
--to=daniel.ritz@gmx.ch \
--cc=feketga@delfin.klte.hu \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®