From: William Lee Irwin III <wli@holomorphy.com>
To: "Adam J. Richter" <adam@yggdrasil.com>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: 2.5.70-bk[56] breaks disk partitioning with multiple IDE disks
Date: Sun, 1 Jun 2003 23:05:46 -0700 [thread overview]
Message-ID: <20030602060546.GM8978@holomorphy.com> (raw)
In-Reply-To: <200306020045.h520j9v15291@freya.yggdrasil.com>
On Sun, Jun 01, 2003 at 05:45:09PM -0700, Adam J. Richter wrote:
> @@ -1436,6 +1437,9 @@
> spin_unlock(&drivers_lock);
> if(idedefault_driver.attach(drive) != 0)
> panic("ide: default attach failed");
> + spin_lock(&drives_lock);
> + list_add_tail(&drive->list, &ata_unused);
> + spin_unlock(&drives_lock);
> return 1;
> }
This looks dubious; check idedefault_driver.attach(). It was just put on
another list. I don't know what you're trying to do but list_move_tail()
would at least not be as oopsable.
-- wli
next prev parent reply other threads:[~2003-06-02 5:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-02 0:45 Adam J. Richter
2003-06-02 6:05 ` William Lee Irwin III [this message]
-- strict thread matches above, loose matches on Subject: below --
2003-06-01 22:59 Adam J. Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030602060546.GM8978@holomorphy.com \
--to=wli@holomorphy.com \
--cc=adam@yggdrasil.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®