From: Sam Ravnborg <sam@ravnborg.org>
To: Anders Gustafsson <andersg@0x63.nu>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [RFC/PATCH] Support for mach-xbox
Date: Mon, 2 Jun 2003 23:56:29 +0200 [thread overview]
Message-ID: <20030602215629.GA11407@mars.ravnborg.org> (raw)
In-Reply-To: <20030602202714.GD18786@h55p111.delphi.afb.lu.se>
On Mon, Jun 02, 2003 at 10:27:14PM +0200, Anders Gustafsson wrote:
> Hi,
>
> Attached is a patch that adds a new subachitecture for the xbox gaming
> system. All it does outside the subarchitecture is adding posibility to
> blacklist pci-devices through an mach-hook.
A few comments.
Sam
> diff -Nru a/arch/i386/boot/compressed/Makefile b/arch/i386/boot/compressed/Makefile
> --- a/arch/i386/boot/compressed/Makefile Mon Jun 2 19:23:26 2003
> +++ b/arch/i386/boot/compressed/Makefile Mon Jun 2 19:23:26 2003
> @@ -5,6 +5,9 @@
> #
>
> targets := vmlinux vmlinux.bin vmlinux.bin.gz head.o misc.o piggy.o
> +ifeq ($(CONFIG_X86_XBOX),y)
> +CFLAGS_misc.o := -O0
> +endif
Add a comment why this special case is needed.
> diff -Nru a/arch/i386/mach-xbox/Makefile b/arch/i386/mach-xbox/Makefile
> --- /dev/null Wed Dec 31 16:00:00 1969
> +++ b/arch/i386/mach-xbox/Makefile Mon Jun 2 19:23:26 2003
> @@ -0,0 +1,7 @@
> +#
> +# Makefile for the linux kernel.
> +#
> +
> +EXTRA_CFLAGS += -I../kernel
Above line is not needed. Kill it.
> +static void xbox_pic_cmd(u8 command){
> + outw_p(((XBOX_PIC_ADDRESS) << 1),XBOX_SMB_HOST_ADDRESS);
> + outb_p(SMC_CMD_POWER, XBOX_SMB_HOST_COMMAND);
> + outw_p(command, XBOX_SMB_HOST_DATA);
> + outw_p(inw(XBOX_SMB_IO_BASE),XBOX_SMB_IO_BASE);
> + outb_p(0x0a,XBOX_SMB_GLOBAL_ENABLE);
> +}
Follow coding style. See Documentation/CodingStyle
- Braces on one line
- Indent with tabs
next prev parent reply other threads:[~2003-06-02 21:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-02 20:27 Anders Gustafsson
2003-06-02 20:50 ` mikpe
2003-06-02 21:01 ` Anders Gustafsson
2003-06-02 21:56 ` Sam Ravnborg [this message]
2003-06-06 14:56 ` Pavel Machek
2003-06-08 9:18 ` Anders Gustafsson
2003-06-08 18:16 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030602215629.GA11407@mars.ravnborg.org \
--to=sam@ravnborg.org \
--cc=andersg@0x63.nu \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®