From: Adrian Bunk <bunk@fs.tum.de>
To: Alan Cox <alan@redhat.com>, Henrique Gobbi <henrique.gobbi@cyclades.com>
Cc: linux-kernel@vger.kernel.org
Subject: [patch] 2.4.21rc6-ac1: fix pc300_drv.c .text.exit
Date: Tue, 3 Jun 2003 17:28:48 +0200 [thread overview]
Message-ID: <20030603152848.GE27168@fs.tum.de> (raw)
In-Reply-To: <200305311153.h4VBrNi21640@devserv.devel.redhat.com>
Trying to compile pc300_drv.c statically into a kernel without hotplug
support results in a .text.exit error at final linking.
The problem is that the pointer to the __devexit cpc_remove_one didn't
use __devexit_p.
The patch below fixes this issue, besides it does a few small cleanups
to the struct.
Please apply
Adrian
--- linux-2.4.21-rc6-ac1-full-nohotplug/drivers/net/wan/pc300_drv.c.old 2003-06-02 22:37:04.000000000 +0200
+++ linux-2.4.21-rc6-ac1-full-nohotplug/drivers/net/wan/pc300_drv.c 2003-06-02 22:42:46.000000000 +0200
@@ -3461,12 +3461,10 @@
}
static struct pci_driver cpc_driver = {
- name:"pc300",
- id_table:cpc_pci_dev_id,
- probe:cpc_init_one,
- remove:cpc_remove_one,
- suspend:NULL,
- resume:NULL,
+ .name = "pc300",
+ .id_table = cpc_pci_dev_id,
+ .probe = cpc_init_one,
+ .remove = __devexit_p(cpc_remove_one),
};
static int __init cpc_init(void)
prev parent reply other threads:[~2003-06-03 15:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-31 11:53 Linux 2.4.21rc6-ac1 Alan Cox
2003-05-31 12:25 ` Gutko
2003-05-31 20:50 ` Andreas Haumer
2003-06-01 7:23 ` ACPI interrupt storm (was Re: Linux 2.4.21rc6-ac1) Paul P Komkoff Jr
2003-06-01 7:31 ` Con Kolivas
2003-06-01 7:23 ` Zwane Mwaikambo
2003-06-03 13:00 ` Con Kolivas
2003-06-01 6:05 ` Linux 2.4.21rc6-ac1 Udo Hoerhold
2003-06-01 11:50 ` Alan Cox
2003-06-01 22:44 ` Udo Hoerhold
2003-06-01 11:45 ` Krzysiek Taraszka
2003-06-01 21:08 ` [patch] 2.4.21rc6-ac1: More IDE Makefile fixes Adrian Bunk
2003-06-02 15:49 ` Linux 2.4.21rc6-ac1 Andreas Haumer
2003-06-03 15:28 ` Adrian Bunk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030603152848.GE27168@fs.tum.de \
--to=bunk@fs.tum.de \
--cc=alan@redhat.com \
--cc=henrique.gobbi@cyclades.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®