From: Andrey Klochko <andrey@morgon.mae.cornell.edu>
To: NeilBrown <neilb@cse.unsw.edu.au>,
Linus Torvalds <torvalds@transmeta.com>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Add module_kernel_thread for threads that live in modules.
Date: Thu, 5 Jun 2003 10:50:16 -0400 [thread overview]
Message-ID: <20030605105016.A9587@morgon.mae.cornell.edu> (raw)
In-Reply-To: <E19NkWO-0005i0-00@notabene.cse.unsw.edu.au>; from neilb@cse.unsw.edu.au on Thu, Jun 05, 2003 at 12:30:32PM +1000
Neil,
On Thu, Jun 05, 2003 at 12:30:32PM +1000, NeilBrown wrote:
> struct svc_serv *serv = rqstp->rq_server;
> @@ -88,7 +88,6 @@ lockd(struct svc_rqst *rqstp)
> unsigned long grace_period_expire;
>
> /* Lock module and set up kernel thread */
> - MOD_INC_USE_COUNT;
> lock_kernel();
>
> /*
> @@ -181,9 +180,7 @@ lockd(struct svc_rqst *rqstp)
> /* release rpciod */
> rpciod_down();
>
> - /* Release module */
> - unlock_kernel();
You've locked the kernel and didn't unlock it.
> - MOD_DEC_USE_COUNT;
> + return 0;
>
Andrey
--
-------------------------------------------------------------
Andrey Klochko
System Administrator
Sibley School of Mechanical and Aerospace Engineering
288 Grumman Hall
Cornell University
Ithaca, NY 14853
e-mail: andrey@mae.cornell.edu
phone: 607-255-0360
next prev parent reply other threads:[~2003-06-05 15:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-05 2:30 NeilBrown
2003-06-05 14:50 ` Andrey Klochko [this message]
2003-06-07 5:33 ` Neil Brown
2003-06-09 16:20 ` Andrey Klochko
2003-06-16 6:50 Rusty Russell
2003-06-16 7:58 ` Martin Diehl
2003-06-16 8:09 ` Rusty Russell
2003-06-16 8:57 ` Martin Diehl
2003-06-16 9:22 ` Rusty Russell
2003-06-16 10:27 ` Martin Diehl
2003-06-17 1:11 ` Rusty Russell
2003-06-16 8:19 ` Andrew Morton
2003-06-16 23:10 ` Neil Brown
2003-06-17 4:25 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030605105016.A9587@morgon.mae.cornell.edu \
--to=andrey@morgon.mae.cornell.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@cse.unsw.edu.au \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®