mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Matthew Wilcox <willy@debian.org>
To: linux-kernel@vger.kernel.org, linux-net@vger.kernel.org
Subject: [PATCH] ethtool_ops
Date: Fri, 6 Jun 2003 15:29:51 +0100	[thread overview]
Message-ID: <20030606142951.GB28581@parcelfarce.linux.theplanet.co.uk> (raw)


The patch is 40k, so I'm not going to post it inline.
http://ftp.linux.org.uk/pub/linux/willy/patches/ethtool.diff

Right now, each network driver which supports the ethtool ioctl has its
own implementation of everything from decoding which ethtool ioctl it is,
copying data to and from userspace, marshalling and unmarshalling data
from ethtool packets, etc.  The current setup makes it impossible to
use alternative interfaces to get at the same data (eg sysfs) and it's
not exactly typesafe.

This patch introduces ethtool_ops and converts tg3 to use it.
Drivers don't access userspace on their own under this scheme; they
just do the requested operation and return the appropriate value(s).
Compile-tested only; design approved by jgarzik.  Comments welcomed.

-- 
"It's not Hollywood.  War is real, war is primarily not about defeat or
victory, it is about death.  I've seen thousands and thousands of dead bodies.
Do you think I want to have an academic debate on this subject?" -- Robert Fisk

             reply	other threads:[~2003-06-06 14:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-06-06 14:29 Matthew Wilcox [this message]
2003-06-06 14:31 ` David S. Miller
2003-06-06 15:50   ` ipNetToMediaTable Ravi Kiran G
2003-06-06 20:17 [PATCH] ethtool_ops Feldman, Scott
2003-06-07 19:09 ` Jeff Garzik
2003-06-30 16:31 ` Matthew Wilcox
2003-06-30 18:46 Feldman, Scott

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030606142951.GB28581@parcelfarce.linux.theplanet.co.uk \
    --to=willy@debian.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-net@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®