From: Sam Ravnborg <sam@ravnborg.org>
To: Andrew Morton <akpm@digeo.com>
Cc: Adrian Bunk <bunk@fs.tum.de>,
bcollins@debian.org, linux1394-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, trivial@rustcorp.com.au
Subject: Re: [patch] 2.5.70-mm5: fix ieee1394_core.c compile if !CONFIG_PROC_FS
Date: Sat, 7 Jun 2003 22:14:57 +0200 [thread overview]
Message-ID: <20030607201457.GA32054@mars.ravnborg.org> (raw)
In-Reply-To: <20030607130625.37f077da.akpm@digeo.com>
On Sat, Jun 07, 2003 at 01:06:25PM -0700, Andrew Morton wrote:
> Adrian Bunk <bunk@fs.tum.de> wrote:
> >
> > I got the following compile error with !CONFIG_PROC_FS:
> >
> > The following patch fixes it:
> > --- linux-2.5.70-mm5/drivers/ieee1394/ieee1394_core.c.old 2003-06-07 16:42:35.000000000 +0200
> > +++ linux-2.5.70-mm5/drivers/ieee1394/ieee1394_core.c 2003-06-07 16:42:47.000000000 +0200
> > @@ -1228,7 +1228,9 @@
> >
> > unregister_chrdev(IEEE1394_MAJOR, "ieee1394");
> > devfs_remove("ieee1394");
> > +#ifdef CONFIG_PROC_FS
> > remove_proc_entry("ieee1394", proc_bus);
> > +#endif
> > }
> >
>
> proc_fs.h has:
>
> static inline void remove_proc_entry(const char *name, struct proc_dir_entry *parent) {};
>
> for the !CONFIG_PROC_FS case, so that _should_ have prevented this problem.
> What went wrong?
proc_bus is only defined when CONFIG_PROC
Sam
prev parent reply other threads:[~2003-06-07 20:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-07 14:45 Adrian Bunk
2003-06-07 20:06 ` Andrew Morton
2003-06-07 20:14 ` Sam Ravnborg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030607201457.GA32054@mars.ravnborg.org \
--to=sam@ravnborg.org \
--cc=akpm@digeo.com \
--cc=bcollins@debian.org \
--cc=bunk@fs.tum.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=trivial@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®