From: Matt Mackall <mpm@selenic.com>
To: Matthew Dobson <colpatch@us.ibm.com>
Cc: Trivial Patch Monkey <trivial@rustcorp.com.au>,
"Martin J. Bligh" <mbligh@aracnet.com>,
linux-kernel@vger.kernel.org
Subject: Re: [patch] use valid value when unmapping cpus
Date: Mon, 9 Jun 2003 00:20:08 -0500 [thread overview]
Message-ID: <20030609052008.GB31216@waste.org> (raw)
In-Reply-To: <3EDE63FE.1010603@us.ibm.com>
On Wed, Jun 04, 2003 at 02:26:22PM -0700, Matthew Dobson wrote:
> For some unknown reason, we stick a -1 in cpu_2_node when we unmap a cpu
> on i386. We're better off sticking a 0 in there, because at least 0 is
> a valid value if something references it. -1 is only going to cause
> problems at some point down the line.
Problems down the line help you find the bogus dereference. Even
better to stick a poison value in there.
--
Matt Mackall : http://www.selenic.com : of or relating to the moon
next prev parent reply other threads:[~2003-06-09 5:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-04 21:26 Matthew Dobson
2003-06-09 5:20 ` Matt Mackall [this message]
2003-06-09 16:59 ` Matthew Dobson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030609052008.GB31216@waste.org \
--to=mpm@selenic.com \
--cc=colpatch@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mbligh@aracnet.com \
--cc=trivial@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®